Skip to content

fix(finance): clarify calc type labels with corresponding RM rate names#66

Merged
ilramdhan merged 1 commit into
mutugading:mainfrom
ilramdhan:fix/master-batch-costing
Jul 15, 2026
Merged

fix(finance): clarify calc type labels with corresponding RM rate names#66
ilramdhan merged 1 commit into
mutugading:mainfrom
ilramdhan:fix/master-batch-costing

Conversation

@ilramdhan

Copy link
Copy Markdown
Member

Description

Pull Request ini memuat perbaikan minor pada sisi UX (teks/copywriting) di modul Finance. Label untuk tipe komputasi (calc type) kini diperbarui agar secara eksplisit mencantumkan nama RM rate (harga bahan baku) pasangannya. Perubahan ini bertujuan untuk menghilangkan kebingungan user (operator/finance) terkait rate mana yang sebenarnya sedang diaplikasikan ketika mereka memilih tipe komputasi tertentu.

Type of Change

  • 🐛 Bug fix
  • ✨ New feature
  • 🎨 UI/UX improvement
  • ♻️ Refactor
  • 📚 Documentation
  • 🔧 Chore (deps, config)

Module/Component Affected

  • Dashboard
  • Finance (Costing / Calc)
  • HR / IT / CI / EXSIM
  • Components (common/)
  • Components (ui/)
  • Navigation
  • API Routes (BFF)

Changes Made

1. UI Label Clarification:

  • Memperbarui teks/label dropdown atau display untuk Calc Type agar menyertakan nama RM rate yang berkorelasi secara langsung.
  • Perubahan ini murni pada layer presentasi/UI untuk kejelasan konteks (contextual clarity) dan tidak mengubah logika komputasi di sisi backend.

Related Issues

Fixes #
Related to #

Screenshots

Before

After

Testing Performed

Manual Testing

  • Desktop (1440px+)
  • Tablet (768px)
  • Mobile (375px)
  • Light mode
  • Dark mode

Browser Testing

  • Chrome
  • Firefox
  • Safari
  • Edge

Build Verification

  • npm run lint passes
  • npx tsc --noEmit passes
  • npm run build succeeds

Accessibility

  • Keyboard navigation works
  • Screen reader compatible
  • Proper ARIA labels
  • Color contrast adequate

Performance

  • No unnecessary re-renders
  • Images optimized
  • Heavy components lazy loaded

Pre-merge Checklist

  • I have read and followed RULES.md
  • I have read and followed CONTRIBUTING.md
  • Loading states implemented (if data fetching)
  • Error handling present
  • Component props typed properly
  • Uses semantic color classes
  • Responsive design tested
  • Dark mode compatible
  • Screenshots included (for UI changes)

Reviewer Notes

  • Copywriting Change: Ini merupakan pembaruan tingkat visual/label saja untuk meningkatkan UX. Pastikan pemetaan nama RM rate yang ditampilkan di teks sudah tepat dan sesuai dengan definisi bisnis costing yang berlaku.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ilramdhan ilramdhan added this to the Costing Release Milestone milestone Jul 15, 2026
@ilramdhan ilramdhan self-assigned this Jul 15, 2026
@ilramdhan ilramdhan added the bug Something isn't working label Jul 15, 2026
Copilot AI review requested due to automatic review settings July 15, 2026 09:20
@ilramdhan ilramdhan added enhancement New feature or request feat fix labels Jul 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ilramdhan
ilramdhan merged commit 50efa47 into mutugading:main Jul 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request feat fix

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants