feat(finance): add MB Head machine picker, RM group colourant details, and MB batch trigger UI - #65
Merged
Conversation
Adds a MachineCombobox scoped to mc_type=MB machines, wired into the MB Head Recipe Identity section (create + update payloads, edit reset from mbHead.machineId). Regenerates yarn_master types for the new machine_id/ mbh_machine_id proto fields. Backs the backend fix that resolves MACHINE_MB_FIXED_TOTAL from a real machine instead of a hardcoded 0. Authored-By: Ilham R <ilhamram332@gmail.com> Co-Authored-By: Ilham R <me@ilramdhan.dev> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: IT Mutugading <it@mutugading.com> Co-Authored-By: Indra Putro <indraputro@mutugading.com> Co-Authored-By: Ilham R <ilham.ramadhan@mutugading.com> Co-Authored-By: IT Mutu Gading <mutugadingapps@gmail.com>
Adds a subtitle (colourant · CI name) to RmGroupHeadCombobox items and two new columns (Colourant, CI Name) to the MB composition table for GROUP-sourced rows, resolved via useRMGroup(groupHeadId). Authored-By: Ilham R <ilhamram332@gmail.com> Co-Authored-By: Ilham R <me@ilramdhan.dev> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: IT Mutugading <it@mutugading.com> Co-Authored-By: Indra Putro <indraputro@mutugading.com> Co-Authored-By: Ilham R <ilham.ramadhan@mutugading.com> Co-Authored-By: IT Mutu Gading <mutugadingapps@gmail.com>
Adds a "Trigger MB Batch" action to the MB Push-to-Head page, gated by finance.mb.batch.trigger permission, with a confirm dialog and a period validity check. Wires the BFF route, TanStack Query hook, API service, and a getMbBatchClient() gRPC client singleton against the already deployed MbBatchService (proto + backend committed previously). Authored-By: Ilham R <ilhamram332@gmail.com> Co-Authored-By: Ilham R <me@ilramdhan.dev> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: IT Mutugading <it@mutugading.com> Co-Authored-By: Indra Putro <indraputro@mutugading.com> Co-Authored-By: Ilham R <ilham.ramadhan@mutugading.com> Co-Authored-By: IT Mutu Gading <mutugadingapps@gmail.com>
ilramdhan
added
bug
github-project-automation
Bot
moved this from Todo
to Done
in Goapps Roadmap [Frontend]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pull Request ini menghadirkan tiga penyempurnaan fitur yang saling melengkapi untuk ekosistem Master Batch (MB) Costing. Pembaruan ini mencakup integrasi Machine Picker pada form MB Head (yang secara tidak langsung menyelesaikan isu hardcode perhitungan di backend), pengayaan informasi Colourant dan CI Name pada antarmuka komposisi RM Group, serta penambahan UI eksekusi komputasi (Trigger MB Batch) secara mandiri di halaman Push-to-Head.
Type of Change
Module/Component Affected
Changes Made
1. MB Head Machine Picker:
MachineCombobox(dibatasi/terfilter hanya untuk mesin denganmc_type=MB) pada seksi Recipe Identity di form MB Head.mbHead.machineId.yarn_masteruntuk mengakomodasi penambahan fieldmachine_id/mbh_machine_id. Pembaruan ini merupakan pilar di frontend untuk mendukung perbaikan di backend yang kini mengambil perhitunganMACHINE_MB_FIXED_TOTALdari mesin asli (bukan lagi hardcode 0).2. RM Group Composition Enhancements:
colourant · CI name) pada item di dalamRmGroupHeadCombobox.GROUP.useRMGroup(groupHeadId).3. MB Batch Compute Trigger UI:
finance.mb.batch.trigger.getMbBatchClient()ke registry gRPC client yang terhubung langsung ke layananMbBatchServicedi backend.Related Issues
Fixes #
Related to #
Screenshots
Before
After
Testing Performed
Manual Testing
Browser Testing
Build Verification
npm run lintpassesnpx tsc --noEmitpassesnpm run buildsucceedsAccessibility
Performance
Pre-merge Checklist
Reviewer Notes
MachineComboboxini sangat krusial karena backend kini mendasarkan perhitungan fixed total (MACHINE_MB_FIXED_TOTAL) pada spesifikasi mesin yang dipilih di form ini. Pastikan untuk memvalidasi bahwa setiap pemilihan mesin baru benar-benar memperbarui payload ID dengan tepat sebelum menekan "Save".finance.mb.batch.trigger. Jika Anda mengujinya dan tidak melihat tombol tersebut, pastikan role akun testing Anda sudah mencakup permission ini.useRMGroup. Pastikan transisi loading pada baris-baris berjenis GROUP berjalan mulus tanpa layout shift yang mengganggu.