Closes #313. Return success flag from GSI solver - #314
Conversation
Add a unit test for the Newton solver class. Uses Rosenbrock function. See #313
Update the return flag from the NewtonSolver's `solve` function to return a success/failure flag based on convergence, rather than returning a reference to `x`, which is redundant because `x` was already passed in by non-const reference. See #313.
Return a boolean indicating success/failure from the GSI `solveSurfaceBalance` routine. Previously was void. See #313.
|
I tested it. It works fine. It is a minor change. The version should be updated to 1.3.0 I would add a function to get the convergence status to be included into the fortran wrapper without breaking backward compatibility. |
|
@capriatim glad it works for you. I didn't bump the version number because this doesn't technically break compatibility. It used to be void. I see two potential ways to add this to the Fortran wrapper. The success flag isn't stored anywhere; it is returned from the |
solveSurfaceBalanceroutines of the GSI solvers to return success or failure based on convergence