Closes #305. Add ability to set GSI solver convergence tolerance from mixture object - #307
Merged
capriatim merged 2 commits intoJun 12, 2026
Conversation
Add the ability to set the write convergence flag for the Newton solver used in the GSI surface balance. The user was already able to set the maximum number of iterations. See mutationpp#305.
Add ability to set the convergence tolerance for the surface balance solvers via the Mixture object. See mutationpp#305.
Collaborator
|
It looks fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #305. Add ability to set GSI solver convergence tolerance from mixture object.
Also adds the ability to set the write convergence flag for the GSI solver.