Skip to content

Unvendor Eigen and bump to 3.4.1 - #288

Merged
rdbisme merged 2 commits into
mutationpp:masterfrom
dalcinl:eigen-unvendor
Dec 28, 2025
Merged

Unvendor Eigen and bump to 3.4.1#288
rdbisme merged 2 commits into
mutationpp:masterfrom
dalcinl:eigen-unvendor

Conversation

@dalcinl

@dalcinl dalcinl commented Dec 14, 2025

Copy link
Copy Markdown
Contributor
  • Unvendor Eigen by removing thirdparty/eigen
  • Bump Eigen to 3.4.1 via CMake/FetchContent

@dalcinl

dalcinl commented Dec 14, 2025

Copy link
Copy Markdown
Contributor Author

@rdbisme What a great PR to bump my GitHub stats!

@dalcinl

dalcinl commented Dec 14, 2025

Copy link
Copy Markdown
Contributor Author

A few comments about FetchContent and its relation to find_package.

  • For more recent CMake versions (>=3.14), the FetchContent approach interoperates with find_package. If Eigen is properly installed in the system, the system installation will be used.
  • For older CMake versions back to 3.14 (when FetchContent was added), the dependency is always fetched from git.

I bumped the CMake requirement to 3.15, one more than the strict minimum for FetchContent, to accommodate for scikit-build-core requirements . If we want to enforce FetchContent/find_package interoperability to always honor system installations, then we need to bump the CMake requirement to 3.24.

@rdbisme
rdbisme merged commit 558306a into mutationpp:master Dec 28, 2025
10 checks passed
@rdbisme

rdbisme commented Dec 28, 2025

Copy link
Copy Markdown
Collaborator

If we want to enforce FetchContent/find_package interoperability to always honor system installations, then we need to bump the CMake requirement to 3.24.

I think we might want to do this aswell.

@dalcinl
dalcinl deleted the eigen-unvendor branch January 5, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants