Enabling to pass surface composition for B' calculation - #279
Merged
Conversation
mgoodson-cvd
left a comment
mgoodson-cvd
left a comment
Collaborator
There was a problem hiding this comment.
I haven't tested this yet, but just from looking at the code, I don't see any reason it shouldn't work.
capriatim
added a commit
to capriatim/Mutationpp
that referenced
this pull request
Jun 10, 2026
capriatim
added a commit
to capriatim/Mutationpp
that referenced
this pull request
Jun 10, 2026
Collaborator
Author
|
@mgoodson-cvd thank you for the review. I addressed the suggested points in the last push. |
mgoodson-cvd
left a comment
mgoodson-cvd
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for addressing my comments. I appreciate the change to preserve backwards compatibility, as well as the version bump. Just a few minor things that I might change, though of course it is fine as-is.
capriatim
added a commit
to capriatim/Mutationpp
that referenced
this pull request
Jun 10, 2026
Collaborator
Author
|
Thank you @mgoodson-cvd . I pushed the last modifications |
Collaborator
|
Looks good to me. |
Collaborator
|
@capriatim Now that all checks are green, I'm going to pull and test, will merge as soon as that is done, hopefully today. |
Collaborator
|
All good, @capriatim rebase on latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.