fix: .gitignore and CHANGELOG were appended with literal backslash-n - #130
Merged
Conversation
The privacy commit (#129) wrote both files through a script whose "\\n" was the two characters backslash-n, not a newline. .gitignore therefore had one line that matched nothing, so config/projects.local.yaml -- the file that holds the real roots -- was NOT ignored (git check-ignore printed nothing). CHANGELOG gained a second, broken [Unreleased] header. Found by the ~/jobd session's cat -A. Both rewritten with real newlines; check-ignore now resolves to .gitignore:32.
tests/test_changelog_fragments.py requires [Unreleased] to stay empty; the broken header from #129 had hidden this entry from that test.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #129.
config/projects.local.yamlwas not actually ignored (the appended .gitignore line contained literal\nsequences), and CHANGELOG had a second broken[Unreleased]header. Verified:git check-ignore -v config/projects.local.yaml→.gitignore:32; one Unreleased header; guard test green.