Skip to content

fix: ensure the module compiles on unsupported platforms#8

Merged
murfffi merged 3 commits into
mainfrom
fix/wasm
Jun 8, 2026
Merged

fix: ensure the module compiles on unsupported platforms#8
murfffi merged 3 commits into
mainfrom
fix/wasm

Conversation

@murfffi

@murfffi murfffi commented Jun 8, 2026

Copy link
Copy Markdown
Owner

skip but compile tests on unsupported platforms

skip but compile tests on unsupported platforms

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces WebAssembly test support in the Makefile, updates build tags to use the unix constraint, and adds a fallback tryPeek implementation for unsupported platforms. The review feedback highlights two main issues: first, the export PATH command in the Makefile's test-wasm target runs in a separate subshell and will not affect the subsequent go test command; second, the platform check in TestDo unnecessarily skips tests on other supported Unix-like platforms like FreeBSD or AIX.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread Makefile Outdated
Comment thread conncheck_test.go Outdated
@murfffi murfffi merged commit 7353fc9 into main Jun 8, 2026
6 checks passed
@murfffi murfffi deleted the fix/wasm branch June 8, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant