fix(bandcamp_importer): convert @include to @match to support MV3#997
Merged
Conversation
arsinclair
commented
Jul 7, 2026
arsinclair
commented
Collaborator
- part of Brave Browser Deactivated ViolentMonkey today #981;
- don't remove @include for now as it requires more testing;
- we will have to drop the possibility of running the script on whitelabelled bandcamp pages: MV3 doesn't support regex in the @match directives, so there's no way to narrow it down. If users complain that the script doesn't run on specific whitelabelled bandcamp pages, we can add those individual pages to the match list.
- webarchive matcher is also more broad now, which justifies an extra guard.
- part of #981; - don't remove @include for now as it requires more testing; - we will have to drop the possibility of running the script on whitelabelled bandcamp pages: MV3 doesn't support regex in the @match directives, so there's no way to narrow it down. If users complain that the script doesn't run on specific whitelabelled bandcamp pages, we can add those individual pages to the match list. - webarchive matcher is also more broad now, which justifies an extra guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.