Skip to content

internetarchive_importer: add new importer#982

Open
Jormangeud wants to merge 1 commit into
murdos:masterfrom
Jormangeud:add_internet_archive_importer
Open

internetarchive_importer: add new importer#982
Jormangeud wants to merge 1 commit into
murdos:masterfrom
Jormangeud:add_internet_archive_importer

Conversation

@Jormangeud

Copy link
Copy Markdown
Contributor

This importer adds releases from the Internet Archive.
Currently supporting https://archive.org/details/*

This importer adds releases from the Internet Archive.
Currently supporting https://archive.org/details/*
@Jormangeud

Copy link
Copy Markdown
Contributor Author

Here are some collections to test with:
https://archive.org/details/audio?and%5B%5D=subject%3A%22music%22&and%5B%5D=mediatype%3A%22collection%22

Libraries are currently using the full url.
I did not add this to README yet.
The various / multiple artist stuff could be probably moved to the mbimport lib.

There is no easy way to know what is failing with the lint check without output or access to the binary.

@arsinclair

Copy link
Copy Markdown
Collaborator

Hey Jormangeud,

The formatting changes are failing the check. You can run pnpm format to fix it, subsequently you can also run eslint locally to see if it passed.

Would it be possible to ask you to convert the script to TypeScript? There's an effort underway to move all scripts to TS and it would be much easier if the new script was initially written in TS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants