Skip to content

feat: add ampwall and subvert importers.#932

Open
djl wants to merge 1 commit into
murdos:masterfrom
djl:ampwall-subvert
Open

feat: add ampwall and subvert importers.#932
djl wants to merge 1 commit into
murdos:masterfrom
djl:ampwall-subvert

Conversation

@djl

@djl djl commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@arsinclair

arsinclair commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Thank you for this PR.

Could you provide links to releases on both platforms to test the scripts. Additionally, could you address all eslint issues present?

@arsinclair

Copy link
Copy Markdown
Collaborator

Also, would it be possible to rewrite the scripts with Typescript, since there's currently an effort underway to convert all of them to Typescript?

It would make sense to do this in order to avoid rewriting them later. But if this is too much, then no problem. We can do it later.

@djl

djl commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

@djl djl force-pushed the ampwall-subvert branch from 6a76129 to 43ed89e Compare June 21, 2026 11:10
@djl

djl commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Silenced the eslint issues.

Started working on the Typescript conversion but doing it Propertly™ is going to take too long right now.

@arsinclair

Copy link
Copy Markdown
Collaborator

Thank you.

Why is it going to take a lot of time? Are any of the pieces missing?

The only shared code I haven't converted to typescript is mblinks.js I think

@djl

djl commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

I was assuming that it had to be converted with full types, like the Beatport converter. If it's just a quick conversion then yeah, easy enough.

@arsinclair

Copy link
Copy Markdown
Collaborator

I guess it definitely makes sense to have it strongly typed instead of relying on any/unknown types, since this is the whole point of Typescript. But you don't have to create extensive types, I think partial types are also fine: only those that you're actually using.

If that's a blocker, then just leave it and we can address it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants