fix(qobuz_importer): Grab Remix/Remaster Information When Importing#917
Open
RazorTwig wants to merge 1 commit into
Open
fix(qobuz_importer): Grab Remix/Remaster Information When Importing#917RazorTwig wants to merge 1 commit into
RazorTwig wants to merge 1 commit into
Conversation
Updating the Qobuz importer script to capture extra title information on both the album and tracks. Things like " (Artist A Remix)" would not get imported into MB automatically because those are not stored as part of the album and track titles by default. Also, trimming the album and track names as I have found a handful of them with trailing spaces, such as Hybrid Theory (20th Anniversary Edition) by Linkin Park (https://www.qobuz.com/us-en/album/hybrid-theory-linkin-park/qzvl42o844ada)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Qobuz importer script does not grab any extra title information for albums or tracks, making it more time consuming to then import into MB.
For instance, for "That Acid (The Remixes)" by Marie Vaunt (https://www.qobuz.com/us-en/album/that-acid-marie-vaunt/gcl6bi92qf73b), the data imported looks like this:
instead of this:
This fix grabs the extra information when parsing the release (from the 'version' attribute) and appends it if it's found.
As part of my testing, I found an album which had a trailing space at the end of its name and so added a call to the string .trim() function when getting the album and track titles as well.
Example of trailing space: "Hybrid Theory (20th Anniversary Edition)" by Linkin Park (https://www.qobuz.com/us-en/album/hybrid-theory-linkin-park/qzvl42o844ada) has an album title of "Hybrid Theory "