Skip to content

fix(bandcamp): remove warning on releases with video links #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rrrnld wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(bandcamp): remove warning on releases with video links #850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions bandcamp_importer.user.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,9 @@ const BandcampImport = {
let showntracks = bandcampAlbumData.trackinfo.length;
let numtracks = -1;
let nostream = false;
// album description indicates number of tracks in the download
let match = /^\d+ track album$/.exec(document.querySelector('meta[property="og:description"]').getAttribute('content'));
if (match) {
numtracks = parseInt(match, 10);
}
// ld+json metadata contains number of tracks in the download
const linkeddata = JSON.parse(document.querySelector('script[type="application/ld+json"]').innerText)
numtracks = linkeddata.numTracks
if (numtracks > 0 && numtracks > showntracks) {
// display a warning if tracks in download differs from tracks shown
$('h2.trackTitle').append(
Expand Down Expand Up @@ -557,12 +555,12 @@ $(document).ready(function () {
<a class="mb_search_link"
class="musicbrainz_import"
target="_blank"
title="Search this artist on MusicBrainz (open in a new tab)"
title="Search this artist on MusicBrainz (open in a new tab)"
href="${artistSearchUrl}"
><small>A</small>?</a>
</span>
<span class="mb_valign mb_searchit">
<a
<a
class="mb_search_link musicbrainz_import"
target="_blank"
title="Search this label on MusicBrainz (open in a new tab)"
Expand Down