Conversation
1) core/file/FileDataBuffer.cpp Проблема: loadData использовала qHash(data 0) для вычисления оригинального хэша, а computeCurrentHashLocked использовала QCryptographicHash Sha256. Это приводило к несовпадению хешей и isModified всегда возвращал true Изменение: Заменён qHash на QCryptographicHash Sha256 2) core/modules/ModuleManager.h Проблема: Метод registerModule был объявлен как const но изменял статическое хранилище через getStorage Изменение: Удалён const из объявления метода 3) widgets/filetreepanel.cpp Проблема: В методе remove индекс из getSourceIndex использовался без проверки валидности. Если индекс не m_fileModel remove получает некорректные данные Изменение: Добавил проверка
Исправил баги в FileDataBuffer, ModuleManager и FileTreePanel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.