Skip to content

performance improvement - #4

Open
TonioF wants to merge 1 commit into
masterfrom
adaptation_for_vm
Open

performance improvement#4
TonioF wants to merge 1 commit into
masterfrom
adaptation_for_vm

Conversation

@TonioF

@TonioF TonioF commented Dec 17, 2018

Copy link
Copy Markdown

No description provided.

@TonioF
TonioF requested a review from jgomezdans December 17, 2018 15:53
@jgomezdans

Copy link
Copy Markdown
Collaborator

I haven't checked if the code is any better, but just to let you know that you have switched off in the main Kafka codebase Hessian calculations, so this code shouldn't be executed as per our previous discussion.

@TonioF

TonioF commented Dec 18, 2018

Copy link
Copy Markdown
Author

That's true, it would make virtually no difference whether we use this version or the one from the master branch. One of them should receive a tag, though.
When I compared this implementation with the original, I got deviations up to 1e-10. To me, this is small enough to be neglected, but maybe you disagree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants