Add GDPR compliance assessment skill - #109
Open
dakshverma23 wants to merge 1 commit into
Open
Conversation
dakshverma23
commented
Jul 15, 2026
- Complete 9-phase workflow for GDPR Article 3-50 assessment
- Article 30 RoPA parser, validator, and report generator scripts
- Framework mappings: NIST CSF 2.0, MITRE ATT&CK
- Compliance scorecard template with weighted scoring
- 2026-current references (ICO, EDPB, Data Use & Access Act)
- Complete 9-phase workflow for GDPR Article 3-50 assessment - Article 30 RoPA parser, validator, and report generator scripts - Framework mappings: NIST CSF 2.0, MITRE ATT&CK - Compliance scorecard template with weighted scoring - 2026-current references (ICO, EDPB, Data Use & Access Act)
rajpratham1
suggested changes
Jul 15, 2026
rajpratham1
left a comment
There was a problem hiding this comment.
Thanks for contributing this GDPR compliance assessment skill. The overall structure is well organized and covers important GDPR topics, including Article 30 records, validation, reporting, and compliance templates.
Before merging, I think a few improvements are needed:
- The report generation script contains a very basic Markdown-to-HTML conversion that relies on string replacements. This is likely to generate invalid HTML for many documents. Consider using a proper Markdown library instead.
- The parser currently relies on simple keyword matching to extract Article 30 information. Since the generated output may be incomplete or inaccurate, the limitations should be documented more prominently and test cases should be included.
- The repository currently does not include automated tests for the parser, validator, or report generator. Adding unit tests would make future maintenance much easier.
- Some documentation contains regulatory statistics and compliance guidance. Please verify that these values are current and reference authoritative sources where appropriate.
- Because this PR introduces more than 2,000 lines of content, adding usage examples or sample input/output files would help reviewers validate the workflow end-to-end.
Overall this is a valuable addition, but I'd like to see these quality and maintainability improvements before approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.