Skip to content

Add guidelines for PR labels - #1209

Closed
Janpot wants to merge 4 commits into
masterfrom
pr-labels
Closed

Add guidelines for PR labels#1209
Janpot wants to merge 4 commits into
masterfrom
pr-labels

Conversation

@Janpot

@Janpot Janpot commented Oct 25, 2022

Copy link
Copy Markdown
Member

Follow up of #849

  • Starting a MAINTAINERS.md as a maintainers guide. Move the release process docs in there. Add a section about PR labelling. Formatted text
  • Update the PR label checker to mandate at least core/docs and add a link to the maintenance guide

@Janpot Janpot added the internal Behind-the-scenes enhancement. Formerly called “core”. label Oct 25, 2022
@render

render Bot commented Oct 25, 2022

Copy link
Copy Markdown

Comment thread MAINTAINERS.md
### location

- `docs`: For updates to the `./docs` folder.
- `core`: For updates Toolpad application and its build environment.

@oliviertassinari oliviertassinari Oct 27, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core is described differently in https://www.notion.so/mui-org/core-c4efa9cabeab49248ff39e583807a2aa. For example, I don't think that #1218 is about core because it directly benefits users, but #1211 is about core because users won't directly care.

Comment thread MAINTAINERS.md
@@ -1,4 +1,30 @@
# Release process
# Maintainers guide

@oliviertassinari oliviertassinari Oct 27, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to only have ## Release process in git because the content needs to be synced with the code. For the rest, I think that Notion is easier to keep up to date, but no objections to have it in git.

@Janpot

Janpot commented Nov 8, 2022

Copy link
Copy Markdown
Member Author

@Janpot Janpot closed this Nov 8, 2022
@Janpot
Janpot deleted the pr-labels branch April 21, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Behind-the-scenes enhancement. Formerly called “core”.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants