[dashboard] Simplify deploy preview to always-valid homepage link#1645
Conversation
Deploy previewBundle sizeTotal Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%) Show details for 69 more bundles@mui/internal-docs-infra/abstractCreateDemo parsed: 0B(0.00%) gzip: 0B(0.00%) PerformanceTotal duration: 15.83 ms ▼-4.18 ms(-20.9%) | Renders: 5 (+0)
5 tests within noise — details Check out the code infra dashboard for more information about this PR. |
brijeshb42
left a comment
There was a problem hiding this comment.
On a side note - I feel the configuration for repos should live on the repo itself somehow.
|
Opening #1649 |
Problem
The Deploy preview comment tried to deep-link each changed doc page by mapping the source path to a published URL. That mapping is unreliable and produced 404s:
docs/data/material/components/buttons/buttons.md→/material-ui/components/buttons(404); the real URL is/material-ui/react-button/(slug comes from routing config, not the folder)..replace(/(customization|guides|…)/, 'material-ui/$1')doubled the prefix →/material-ui/material-ui/customization/palette(404), as seen on [docs] Add blog post for enhanceHighContrast material-ui#48753..mdchanges (demos,teamMembers.json) were detected as nothing.Change
Stop guessing per-page URLs. The deploy-preview root is the only link we can build reliably, so:
docsPathprefix per repo (docs/data/for material-ui & mui-x,docs/app/docs-infra/for mui-public).formatDocPathURL-mapping config entirely.Fixes the #48753 broken link and removes the component 404s.