Skip to content

Create ultrasonic.c#45

Open
moranod3 wants to merge 1 commit into
muhlbaier:masterfrom
moranod3:master
Open

Create ultrasonic.c#45
moranod3 wants to merge 1 commit into
muhlbaier:masterfrom
moranod3:master

Conversation

@moranod3

@moranod3 moranod3 commented May 1, 2019

Copy link
Copy Markdown
Contributor

Code works for a single sensor, the code for the second sensor is still buggy. The timer for the second sensor does not count at the correct speed and still needs to be fixed. Changes made to ultrasonic.h since the Ultrasonic_Init function does not pass filter_t, or the callback into the function in the working code.

Code works for a single sensor, the code for the second sensor is still buggy. The timer for the second sensor does not count at the correct speed.

@muhlbaier muhlbaier left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too processor specific to be acceptable. There should be a hal_ultrasonic.c or similar to implement the processor specific code. You don't need to support more than one processor but the module needs to be portable otherwise it isn't a module it is just a chunk of application specific code.

@moranod3

moranod3 commented May 8, 2019

Copy link
Copy Markdown
Contributor Author

What exactly is processor specific, because I know when we presented this you told us the hal_ultrasonic file we had was unnecessary. I'm assuming its the code in the Timer and Port interrupts but not 100% sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants