Select the fallback on wasip1/wasip2 - #213
Open
calvinrp wants to merge 1 commit into
Open
Conversation
Building termenv for GOOS=wasip1 (added in Go 1.21) fails with undefined ColorProfile/foregroundColor/backgroundColor/ EnableVirtualTerminalProcessing: the per-GOOS files cover the concrete OSes and termenv_other.go is gated js || plan9 || aix only. WASI has no terminal control either, so the same fallback is correct there; add wasip1 and wasip2 to its build tags, matching the file's tag style. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, and thanks for maintaining termenv!
Since Go 1.21 added
GOOS=wasip1(WASI preview 1), building termenv for the WASI platforms fails, because none of the per-platform files is selected there:termenv_unix.go/termenv_solaris.go/termenv_windows.gocover the concrete OSes, and the fallbacktermenv_other.gois gatedjs || plan9 || aixonly. This breaks downstream users on wasip1 — for examplegh(github.com/cli/cli) and the glow/bubbletea stack.WASI has no terminal status queries either, so the existing fallback (ANSI256 profile, default fg/bg, no-op VT toggle) is the correct behavior there as well. This PR just adds
wasip1andwasip2to the fallback's build tags, matching the file's existing tag style.Verified:
GOOS=wasip1 GOARCH=wasm go build ./...now succeeds, selectingtermenv_other.go🤖 Generated with Claude Code