Repository navigation
M6: retain document-script errors in console and button output - #1
Open
enriquemelzer-bit wants to merge 1 commit into
Conversation
mtlcl410
pushed a commit
that referenced
this pull request
Oct 30, 2026
Merge main; set typing_from in two tests from storytold#4441
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Follow-up for Brandon's review of storytold/pdfcraft#3985, based directly on that PR's head
994ce630. This targets the existing feature branch so the fix can be incorporated into storytold#3985.run_consoleandrun_button_scriptnow include document-script errors in the visibleJsOutput.errorslist and retain theirdoc_errorsprovenance. The console displaysError: ...while keeping successful completion values; buttons retain their field changes, alerts and output. Errors from the explicitly executed script remain separate.Two UI regressions cover successful execution after a document error, simultaneous document/console or document/button failures, and a button whose only output is the document error. The console test clicks Run and both tests check visible console labels.
Also includes one behavior-preserving boolean simplification in
compare_ui.rsrequired by Rust 1.95's strict Clippy check, plus parity evidence, progress notes and my previously chosen public-profile credit preference.How you verified it
pdfcraft-ui-eguisuite: 1,557 passed, 0 failed, 5 existing ignored (533 unit, 1,021 integration, 3 performance).cargo fmt --all -- --check.cargo clippy -p pdfcraft-ui-egui --all-targets --no-deps -j 2 -- -D warnings.cargo xtask layers,cargo xtask assets,cargo xtask parity.cargo check -p pdfcraft-ui-egui --target wasm32-unknown-unknown -j 2passed; existing target-specific unused-code warnings remain.42retained.PDFCRAFT_SYSTEM_FONTS=0.Validation ran on Windows with Rust 1.95,
--locked --offline, two build jobs and serial tests. A local-only Cargo configuration reduces debug information to match current main; no Cargo manifest or lockfile changes are included. File-writing tests ran outside the filesystem sandbox after confirming its restriction caused the existing CSV test to fail.Safety, provenance and reach
No new panic paths, unsafe code, assets, fonts, network access, or permission changes. Tests reuse the existing synthetic form fixture. The engine and
js_runbehavior from storytold#3985 are unchanged; this repairs the UI adapters. Parity evidence now names the two UI regressions.