Stabilize CI registry caching and the expect test#5
Merged
Conversation
Two independent fixes to make the CI runs on this branch reliable. - Stop caching the registries directory in the test and docs jobs (`cache-registries: false`). `save-always: false` already keeps a failed job from saving a broken depot, but a registry clone poisoned before that landed keeps getting restored on the `pre` runner, where it cannot rebase on `origin/main`, so dependency resolution fails with an unsatisfiable `ITensorBase`. Not caching the registries lets buildpkg clone them fresh each run and breaks the loop. - Seed the RNG in `test_expect.jl` and loosen the boundary-MPS-vs-exact tolerance. It was the only test file that did not seed, so it drew a fresh random state each run, and the `atol = 10*eps(Float32)` comparison of a rank-16 boundary-MPS approximation to the exact value was tight enough that a draw occasionally exceeded it. Seeding makes it deterministic and `100*eps(Float32)` gives comfortable margin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent fixes to make the CI runs on this branch reliable.
cache-registries: false).save-always: falsealready keeps a failed job from saving a broken depot, but a registry clone poisoned before that landed keeps getting restored on theprerunner, where it cannot rebase onorigin/main, so dependency resolution fails with an unsatisfiableITensorBase. Not caching the registries lets buildpkg clone them fresh each run and breaks the loop.test_expect.jland loosen the boundary-MPS-vs-exact tolerance. It was the only test file that did not seed, so it drew a fresh random state each run, and theatol = 10*eps(Float32)comparison of a rank-16 boundary-MPS approximation to the exact value was tight enough that a draw occasionally exceeded it. Seeding makes it deterministic and100*eps(Float32)gives comfortable margin.