Update version #41 #45 - #52
Merged
Merged
Conversation
Refactor board UI and update core game-engine logic and tests. Client package.json updated and Board/File/Tile components modified to adjust UI/behavior. Game-engine changes include updates to piece utilities (getPlayerKing, getPlayerPieces), position helpers (addToRank), bot behavior (CaptureIfAvailableBot), test utilities and snapshots, plus an updated performance e2e test and tsconfig. Server changes update app module and lobby service and adjust the e2e Jest config. Added debug.log.
mterczynski
reviewed
May 1, 2026
mterczynski
reviewed
May 1, 2026
mterczynski
reviewed
May 1, 2026
mterczynski
reviewed
May 1, 2026
mterczynski
reviewed
May 1, 2026
mterczynski
reviewed
May 1, 2026
mterczynski
reviewed
May 1, 2026
mterczynski
reviewed
May 1, 2026
mterczynski
reviewed
May 1, 2026
mterczynski
reviewed
May 1, 2026
mterczynski
reviewed
May 1, 2026
mterczynski
reviewed
May 1, 2026
mterczynski
reviewed
May 1, 2026
Adjust module imports and TypeScript configs, and small housekeeping. - Update several imports to point to concrete module paths (e.g. types/King, types/PieceType, src/Game, src/Board, src/pieces, src/positions) to fix resolution. - Simplify game-engine/tsconfig.json for production (remove jest/node types, restrict include to ./src) and add game-engine/tsconfig.test.json that extends it and enables jest/node types for tests (noEmit). - Add debug.log (runtime error log) to repo. - Remove an unnecessary ESLint disable comment in server lobby.service after removing the unused variable.
There was a problem hiding this comment.
Pull request overview
This PR updates dependency versions across the monorepo, expands workspace usage (including the shared package), and applies a set of related configuration and codebase adjustments in the server, game-engine, and client packages.
Changes:
- Bumped package versions across root/server/client and added workspace dependencies (
chess-shared,game-engine). - Updated NestJS server module wiring and Jest configuration (including e2e patterns).
- Refactored game-engine TypeScript/Jest setup and internal imports, with regenerated snapshots and adjusted performance test threshold.
Reviewed changes
Copilot reviewed 20 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/test/jest-e2e.json | Adjusts server e2e Jest pattern matching. |
| server/src/app.module.ts | Changes DevtoolsModule registration behavior based on runtime env. |
| server/package.json | Updates server dependencies/devDependencies and adds workspace deps. |
| package.json | Updates root workspaces and dependency versions. |
| game-engine/tsconfig.test.json | Adds a test-focused TS config for game-engine. |
| game-engine/tsconfig.json | Updates game-engine compiler options and include patterns. |
| game-engine/test-utils/getEmptyBoard.test.ts | Updates imports to use game-engine public exports. |
| game-engine/src/positions/addToRank.ts | Changes Rank import path within positions module. |
| game-engine/src/positions/addToFile.unit.test.ts | Updates ChessFile import path. |
| game-engine/src/pieces/getPlayerPieces.ts | Switches to barrel export import for types. |
| game-engine/src/pieces/getPlayerKing.test.ts | Switches to barrel export import for types. |
| game-engine/src/pieces/snapshots/getPlayerPieces.unit.test.ts.snap | Updates snapshots after formatting/output changes. |
| game-engine/src/bots/RandomMoveBot.test.ts | Updates ChessFile import to barrel export. |
| game-engine/src/bots/CaptureIfAvailableBot.ts | Refactors imports (utils barrel + lodash default import). |
| game-engine/src/snapshots/Game.int.test.ts.snap | Updates snapshots after formatting/output changes. |
| game-engine/e2e-tests/performance.e2e.test.ts | Lowers performance threshold to reduce flakiness. |
| debug.log | Adds a new log file to the repo. |
| client/src/board/Tile.tsx | Removes tile border styling from styled component. |
| client/src/board/File.tsx | Removes first-child border styling from file container. |
| client/src/board/Board.tsx | Removes board border styling from board container. |
| client/package.json | Updates client dependencies (React, styled-components, workspace deps). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update package dependency versions across the repo (notably client and server package.json files) to pick up newer React, react-dom, styled-components, react-query, TypeScript toolchain and Vite plugin versions. Remove scripts/link-packages.sh and delete the README reference to the postinstall package linking step; update scripts/README.md accordingly. Miscellaneous package metadata updates in root and server package manifests.
mterczynski
reviewed
Jun 6, 2026
mterczynski
reviewed
Jun 6, 2026
mterczynski
reviewed
Jun 6, 2026
mterczynski
reviewed
Jun 6, 2026
mterczynski
reviewed
Jun 6, 2026
mterczynski
reviewed
Jun 6, 2026
Add explicit borders between board columns and tile borders to improve grid rendering (Board.tsx, Tile.tsx). Small styling and formatting tweaks in PromotionMenu.tsx and Board.tsx. Remove server e2e lobby spec and update server package/jest config. Regenerate package-lock.json.
Modify package.json and regenerate package-lock.json. Adds runtime deps @emotion/is-prop-valid and stylis (client stylis node_module entry), and introduces/updates many dev dependencies (Jest 30.x ecosystem and related @jridgewell packages). The lockfile also removes/restructures several inquirer-related entries and refreshes transitive dependency metadata. This commit syncs the lockfile with the updated package.json and dependency changes.
Replace testRegex with a testMatch glob in server/test/jest-e2e.json to match **/*.e2e-spec.ts files. Add "types": ["jest"] to server/tsconfig.json compilerOptions so TypeScript picks up Jest typings for tests.
Modify project dependencies in package.json and regenerate package-lock.json to update the resolved dependency tree. The lockfile was refreshed to reflect the dependency changes and their transitive resolutions; run npm install to reproduce the updated lockfile.
mterczynski
reviewed
Jun 6, 2026
Change styled-component props to use transient ($-prefixed) names so they aren't passed through to DOM elements. Updated Tile.tsx to use $color for TileBackground and its usage, CreateLobbyForm.tsx to use $gray on the Back button, and PlayerSelectionScreen.tsx to use $color in the Button styled props and references. This prevents React warnings about unknown DOM attributes and keeps styling props internal to styled-components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update version in repository to latest and add some changes in files
Resolves #41 Resolves #45