Skip to content

Remove redundant npm link in favor of workspace dependencies - #42

Draft
mterczynski with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-active-game-status
Draft

Remove redundant npm link in favor of workspace dependencies#42
mterczynski with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-active-game-status

Conversation

Copilot AI commented Jan 24, 2026

Copy link
Copy Markdown
Contributor

The repository was using both npm workspaces and manual npm link commands via a postinstall script, causing unnecessary complexity.

Changes

  • Added explicit workspace dependencies: Declared game-engine and chess-shared in client and server package.json dependencies
  • Removed manual linking: Deleted scripts/link-packages.sh and updated postinstall to just build the game-engine
  • Added Vite aliases: Configured path resolution for workspace packages in client bundler
  • Updated workspace config: Added shared package to workspaces array

Before

# postinstall script
bash scripts/link-packages.sh  # 41 lines of manual npm link/unlink commands

After

# postinstall script  
npm run build:engine  # workspaces handle linking automatically

npm workspaces (enabled in root package.json) already creates symlinks in node_modules automatically when workspace packages are declared as dependencies. The manual linking was redundant.

Original prompt

#41


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: mterczynski <27309340+mterczynski@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix active game status not updating correctly Remove redundant npm link in favor of workspace dependencies Jan 24, 2026
Copilot AI requested a review from mterczynski January 24, 2026 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants