Skip to content

Fix/doi access free pr - #5717

Merged
GlazerMann merged 2 commits into
ms609:masterfrom
redalert2fan:fix/doi-access-free-pr
Aug 7, 2026
Merged

Fix/doi access free pr#5717
GlazerMann merged 2 commits into
ms609:masterfrom
redalert2fan:fix/doi-access-free-pr

Conversation

@redalert2fan

Copy link
Copy Markdown
Contributor

Summary

  • Avoid adding duplicate doi-access=free parameters.
  • Upgrade existing non-free DOI access values when the DOI is known to be free.
  • Add regression tests for both cases.
  • Use mb_substr_count() in tests to satisfy PHPCS.

Test Plan

  • Focused DOI access tests pass: 5 tests, 9 assertions.
  • Changed files are limited to Template.php and templatePart4Test.php.

@redalert2fan

Copy link
Copy Markdown
Contributor Author

test fail unrelated to this patch, should be fixed by #5716

@GlazerMann
GlazerMann merged commit cb8c1e1 into ms609:master Aug 7, 2026
18 of 21 checks passed
@redalert2fan
redalert2fan deleted the fix/doi-access-free-pr branch August 7, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants