Skip to content
This repository was archived by the owner on Mar 11, 2022. It is now read-only.

Add event bus to sync locale between nova-translatable field instances - #15

Open
cdupoiron wants to merge 1 commit into
mrmonat:masterfrom
cdupoiron:sync-locale-tab-between-fields
Open

Add event bus to sync locale between nova-translatable field instances#15
cdupoiron wants to merge 1 commit into
mrmonat:masterfrom
cdupoiron:sync-locale-tab-between-fields

Conversation

@cdupoiron

Copy link
Copy Markdown

No description provided.

@mrmonat

mrmonat commented Sep 14, 2018

Copy link
Copy Markdown
Owner

Hi, thanks for your pull request, i like the idea, but I think we could use the global Nova Event Bus, instead of using our own? (what do you think?)
I saw a parameter dontEmit, where would this be set? I think we should make it configurable in config/translatable.php and add an extra method to override it something linke ->emitChanges(true/false)

@cdupoiron

Copy link
Copy Markdown
Author

Hi,
OK, great idea, is there a doc about the global Nova Event Bus?

OK to make it configurable

@mrmonat

mrmonat commented Sep 14, 2018

Copy link
Copy Markdown
Owner

Yes, you can find the documentation for the Event Bus here: https://nova.laravel.com/docs/1.0/customization/frontend.html#javascript

@cdupoiron

Copy link
Copy Markdown
Author

OK, thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants