Phase 1: golden fixture harness — the Definition of Working - #6
Merged
Conversation
The Definition of Working (MASTER_PLAN Phase 1):
- tests/golden/translation_cases.json — 24 fixtures (medical, emergency,
modal, aspect, question, rights, regression, hostile, exploratory),
every expectation verified against real pipeline output
- tests/golden/sign_reconstruction_cases.json — 6 intent-level fixtures
- tests/golden/scoring.py — scorer with required/forbidden signs, marker
preservation, WORD-ORDER pairs (the SASL axis a bag-of-signs metric
misses), and avatar-library compliance (signs_library.js is ground
truth, not the transformer JSON)
- pytest gates: every critical case must pass; baseline printed in CI
Bugs the harness caught on its first run, all fixed with regressions:
1. 'need' → 'NE' (naive -ed stripping; min stem length + eed guard)
2. false FINISH aspect from -s/-ing forms ('My chest hurts' was past)
3. 'walking' → 'WALKE' (silent-e heuristic; library-aware + irregular map)
4. RIGHTS → RIGHT (library signs must never be re-stemmed)
Vocabulary: NEED added to signs_library.js as a review-flagged placeholder
(conf 2, MUST-family motion) — the top clinic verb was unplayable. The
remaining 16-sign transformer/avatar gap is recorded in MASTER_PLAN for
Phase 3 real-data recording.
Baseline: 24/24 golden cases, 16/16 critical, mean recall 1.0.
Suite: 137 passed.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executes MASTER_PLAN.md Phase 1:
signs_library.jsas ground truthFour real grammar bugs caught by the harness on its first run, all fixed with regressions:
Vocabulary hole found: NEED — the top clinic verb — was absent from the avatar library; added as review-flagged placeholder (conf 2). The measured 16-sign transformer/avatar gap is recorded in the plan for Phase 3 real-data recording.
Baseline: 24/24 golden, 16/16 critical, mean recall 1.0. Suite: 137 passed.
🤖 Generated with Claude Code