Fix generate() to accept additional generation parameters - #9
Merged
Conversation
…ional parameters Co-authored-by: mrinalchaturvedi27 <203689324+mrinalchaturvedi27@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error in multi-GPU training script
Fix generate() to accept additional generation parameters
Feb 5, 2026
mrinalchaturvedi27
marked this pull request as ready for review
February 5, 2026 18:24
There was a problem hiding this comment.
Pull request overview
This pull request fixes a TypeError that occurred when Trainer.evaluate() called SignLanguageTranslationModel.generate() with additional generation parameters (length_penalty, no_repeat_ngram_size, and early_stopping) that the method didn't accept.
Changes:
- Added
**kwargsparameter to thegenerate()method signature to accept additional generation parameters - Forwarded kwargs to the underlying HuggingFace model's generate method for both encoder-decoder and causal LM code paths
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trainer.evaluate()passeslength_penalty,no_repeat_ngram_size, andearly_stoppingtogenerate(), butSignLanguageTranslationModel.generate()didn't accept these parameters, causing aTypeErrorduring training.Changes
**kwargstoSignLanguageTranslationModel.generate()signatureWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
huggingface.cofrom transformers import AutoModelForSeq2SeqLM, AutoConfig, AutoTokenizer
import inspect
Check generate method signature
model = AutoModelForSeq2SeqLM.from_pretrained('t5-small')
print('Generate parameters:')
sig = inspect.signature(model.generate)
fo` (dns block)
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.