Centralise validation of mvepiestim inputs - #245
Open
sangeetabhatia03 wants to merge 14 commits into
Open
Conversation
Collaborator
Author
|
hi @annecori @steffilazerte just flagging that the lint errors on this PR have been addressed in PR#244. |
steffilazerte
approved these changes
Jun 4, 2026
steffilazerte
left a comment
Collaborator
There was a problem hiding this comment.
Hi @sangeetabhatia03, I reviewed as best I can, considering my unfamiliarity. Looks good to me and I think has a lot of added value in the DRY principle!
I asked a couple of questions, but mostly just for points of thought, not things that must change (for example, should you add .call = FALSE to the warnings and stops that you move? I'm not sure they'll be delinted otherwise?)
See what you think. Merge when you're ready!
steffilazerte
approved these changes
Jun 29, 2026
steffilazerte
left a comment
Collaborator
There was a problem hiding this comment.
Just in case you wanted a review from me: looks good 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address issue #189
draw_Randdraw_epsilonwhich are called viaestimate_advantageestimate_advantage; our current handling of this was inconsistent as we normalised if the user did not specifyt_minand did not normalise ift_minwas provided. Further, the code for normalising was also incorrect (fixed now)