Skip to content

Create CODE_DESIGN.md - #235

Merged
sangeetabhatia03 merged 6 commits into
mainfrom
steffi-design
Jun 26, 2026
Merged

Create CODE_DESIGN.md#235
sangeetabhatia03 merged 6 commits into
mainfrom
steffi-design

Conversation

@steffilazerte

Copy link
Copy Markdown
Collaborator

Fixes #217
Add RELEASE.R and CODE-DESIGN.md as starting points (CODE-DESIGN.md in particular could be filled in more, especially "Be Careful" and a "Future ideas" section (or Roadmap) could also be added.

Also added CONTRIBUTING.md

@annecori annecori left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Wondering if @sangeetabhatia03 and or @thibautjombart want to have a look to?

Comment thread CODE-DESIGN.md Outdated
Comment thread CODE-DESIGN.md Outdated
steffilazerte and others added 3 commits March 27, 2026 14:30
@steffilazerte

Copy link
Copy Markdown
Collaborator Author

Great! I'll leave this PR open for now to see if there are any other comments. Especially if anyone remembers being confused when the first started working on EpiEstim until they understood something (then add that something to the CODE-DESIGN.md 😁)

@annecori

Copy link
Copy Markdown
Collaborator

@sangeetabhatia03 @thibautjombart @rebeccanash @abriz97 I would be grateful if you could have a look at this PR and add anything you can think of. Thanks!

@sangeetabhatia03

Copy link
Copy Markdown
Collaborator

Looks good @steffilazerte My only suggestion is to not use the double colon syntax of the package is already listed as imports, but that's a personal preference as I find that it makes the code less readable. So I'd defer to you! Otherwise I can't think of anything else off the top of my head.

@steffilazerte

Copy link
Copy Markdown
Collaborator Author

@sangeetabhatia03, pkg::fun() does make the code a bit busier for sure! However, in a package development context it does have the benefit of making it very clear what package the function comes from. If we don't use that syntax, we have to either import the whole package or the functions required (listing the packages in Imports in the DESCRIPTION isn't sufficient). This can get a bit messy. Generally, best practice is to use :: as much as possible, and then use @importFrom pkg fun1 fun2 for functions that you use a lot (and which might be relatively well known functions from well known packages).

Where that line is depends on the developer 😁

@sangeetabhatia03

Copy link
Copy Markdown
Collaborator

Another suggestion: I think it would be good to enforce consistency using tidyverse style guide in places; specifically I am thinking using return() for early returns, and otherwise having the function return the last evaluated expression.

@steffilazerte

steffilazerte commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

Added! Just need someone to approve the PR

@sangeetabhatia03
sangeetabhatia03 merged commit 3b9e5ca into main Jun 26, 2026
10 checks passed
@sangeetabhatia03
sangeetabhatia03 deleted the steffi-design branch June 26, 2026 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create CODE_DESIGN.md

3 participants