Create CODE_DESIGN.md - #235
Conversation
annecori
left a comment
There was a problem hiding this comment.
This looks good to me. Wondering if @sangeetabhatia03 and or @thibautjombart want to have a look to?
Co-authored-by: anne cori <annecori@users.noreply.github.com>
|
Great! I'll leave this PR open for now to see if there are any other comments. Especially if anyone remembers being confused when the first started working on EpiEstim until they understood something (then add that something to the CODE-DESIGN.md 😁) |
|
@sangeetabhatia03 @thibautjombart @rebeccanash @abriz97 I would be grateful if you could have a look at this PR and add anything you can think of. Thanks! |
|
Looks good @steffilazerte My only suggestion is to not use the double colon syntax of the package is already listed as imports, but that's a personal preference as I find that it makes the code less readable. So I'd defer to you! Otherwise I can't think of anything else off the top of my head. |
|
@sangeetabhatia03, Where that line is depends on the developer 😁 |
|
Another suggestion: I think it would be good to enforce consistency using tidyverse style guide in places; specifically I am thinking using |
|
Added! Just need someone to approve the PR |
Fixes #217
Add RELEASE.R and CODE-DESIGN.md as starting points (CODE-DESIGN.md in particular could be filled in more, especially "Be Careful" and a "Future ideas" section (or Roadmap) could also be added.
Also added CONTRIBUTING.md