Fix webhook payload issues and release workflow hardening - #106
Open
mrb0nj wants to merge 2 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR delivers v1.1.6 with three core enhancements: unfurl controls for Slack message links/media, JSON property name correction for PlainTextInput multiline serialization, and implicit string-to-TextObject conversion. It includes CI workflow security updates with pinned action versions and release documentation reflecting the new features. ChangesSlack Webhooks Features and Fixes
Release Infrastructure
🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
src/Slack.Webhooks/Slack.Webhooks.csproj (1)
16-16: ⚡ Quick winRelease notes are missing one shipped feature.
Please include the implicit
string→TextObjectconversion inPackageReleaseNotesso NuGet metadata matches the release scope.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/Slack.Webhooks/Slack.Webhooks.csproj` at line 16, Update the <PackageReleaseNotes> XML value to include the shipped implicit string → TextObject conversion so NuGet release metadata reflects that feature; locate the <PackageReleaseNotes> element in the project file (the current text: "Adds Slack webhook unfurl options, fixes plain-text input multiline serialization, and keeps modern NuGet package metadata.") and append or integrate a short phrase mentioning "implicit string → TextObject conversion" (or equivalent wording) so the release notes enumerate that feature explicitly.src/Slack.Webhooks/Elements/TextObject.cs (1)
63-66: 💤 Low valueImplicit operator correctly simplifies TextObject creation.
The operator allows
TextObject obj = "text"andSection.Text = "text"assignments, addressing issue#85. The defaultType = TextType.PlainTextis a reasonable choice for plain string conversions.Optional: Consider adding XML documentation
Adding an XML doc comment would clarify the default behavior for users:
+ /// <summary> + /// Implicitly converts a string to a <see cref="TextObject"/> with <see cref="Type"/> set to <see cref="TextType.PlainText"/>. + /// </summary> public static implicit operator TextObject(string text) { return new TextObject(text); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/Slack.Webhooks/Elements/TextObject.cs` around lines 63 - 66, Add an XML documentation comment to the implicit conversion operator in TextObject to document that implicitly converting from string constructs a new TextObject with Type = TextType.PlainText and assigns the provided text; update the comment above the operator method (the implicit operator in class TextObject) to clearly state the default behavior and intended usage (e.g., "Enables assigning a string to a TextObject or Section.Text; defaults to PlainText") so consumers and IDE tooltips see the behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 102-106: Update the mention guidance sentence to accurately
reflect the example by stating that Slack user, broadcast (here), and channel
mentions are supported; e.g., modify the text that precedes the code example
referencing slackMessage.Text and the sample string "<`@U12345678`> <!here>
<!channel>" so it explicitly includes channel mentions alongside user and
broadcast mentions.
---
Nitpick comments:
In `@src/Slack.Webhooks/Elements/TextObject.cs`:
- Around line 63-66: Add an XML documentation comment to the implicit conversion
operator in TextObject to document that implicitly converting from string
constructs a new TextObject with Type = TextType.PlainText and assigns the
provided text; update the comment above the operator method (the implicit
operator in class TextObject) to clearly state the default behavior and intended
usage (e.g., "Enables assigning a string to a TextObject or Section.Text;
defaults to PlainText") so consumers and IDE tooltips see the behavior.
In `@src/Slack.Webhooks/Slack.Webhooks.csproj`:
- Line 16: Update the <PackageReleaseNotes> XML value to include the shipped
implicit string → TextObject conversion so NuGet release metadata reflects that
feature; locate the <PackageReleaseNotes> element in the project file (the
current text: "Adds Slack webhook unfurl options, fixes plain-text input
multiline serialization, and keeps modern NuGet package metadata.") and append
or integrate a short phrase mentioning "implicit string → TextObject conversion"
(or equivalent wording) so the release notes enumerate that feature explicitly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1292280f-0c84-4a7d-8335-cb9b92d00b24
📒 Files selected for processing (9)
.github/workflows/main.ymlREADME.mdsrc/Slack.Webhooks.Tests/PlainTextInputElementFixtures.cssrc/Slack.Webhooks.Tests/SectionBlockFixtures.cssrc/Slack.Webhooks.Tests/SlackMessageFixtures.cssrc/Slack.Webhooks/Elements/PlainTextInput.cssrc/Slack.Webhooks/Elements/TextObject.cssrc/Slack.Webhooks/Slack.Webhooks.csprojsrc/Slack.Webhooks/SlackMessage.cs
This was referenced Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issues
Validation
Summary by CodeRabbit
New Features
Documentation
Bug Fixes
Tests
Chores