Skip to content

Modernize Desktop-Notifier#711

Closed
amotl wants to merge 2 commits into
mqtt-tools:mainfrom
ignorantbliss:main
Closed

Modernize Desktop-Notifier#711
amotl wants to merge 2 commits into
mqtt-tools:mainfrom
ignorantbliss:main

Conversation

@amotl

@amotl amotl commented Jul 12, 2026

Copy link
Copy Markdown
Member

About

  • Desktop-Notifier no longer supports sync calls.
  • Permit working with non-string data (i.e. dictionaries).

References

Rough fix for mqtt-tools#706 - sync calls no longer support by current library version.

Also allows service to work with non-string data (ie. dictionaries).
Added 'get_option_value' function for use in process_job. This function allows overriding transform options on a per-source/per-target basis.
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)
  • coderabbit-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dbf0535e-c3a4-4611-87ff-a58d6a3100ac

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@amotl

amotl commented Jul 12, 2026

Copy link
Copy Markdown
Member Author

Deferred to GH-712, because I can't push to the remote branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants