Search the whole grid when one permission is selected in non-granular mode#3
Open
mpmadhavig wants to merge 4 commits into
Open
Search the whole grid when one permission is selected in non-granular mode#3mpmadhavig wants to merge 4 commits into
mpmadhavig wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Legacy (non-granular) console permission mode now lights up every row whose eligibility scopes the selection covers — the same "impact closure" behaviour granular mode already had. Selecting Edit or View on a single row now propagates to every other row backed by the same underlying management scopes.
Changes
create-console-role-wizard-permissions-form.tsx: addedderiveLegacySelectedFromScopesandapplyLegacySelectionChange— legacy counterparts of the granular derive/apply pair. Every legacy row change (checkbox, read/write toggle, accordion select-all) funnels through a sharedsetLegacyRowLevelhelper so the closure fires uniformly. Fixed accordion select-all indeterminate state and wired it to the tenant checkbox.console-role-permissions.tsx(role-edit view): removed theuseEligibilityScopesflag so per-action feature scopes are always stripped from eligibility, keeping the edit view in lockstep with the wizard.get-eligibility-scope-names.ts: added_viewto the per-action feature scope suffix list. Without it,console:<feature>_viewplaceholders were being retained in eligibility checks and blocking coverage tests for collections whose write scope set implicitly depended on the view scope.user-groups-edit.tsx: guardeduseRequiredScopesagainst undefined.console-settings.ts(i18n): rewordedpermissionsCountto be count-safe.Test plan
_viewstrip also benefits granular's View column but no regression to existing paths).Notes
granular-console-scopes-baseon this fork; will retarget tomasteronce Granular console scopes wso2/identity-apps#10458 merges.