Bridge IRCv3 replies and reactions with late.sh chat#434
Open
mevanlc wants to merge 13 commits into
Open
Conversation
- add IRCv3 overview and feature definitions
- add architecture/implementation ideas and tiered rollout plan
# Conflicts: # late-ssh/src/ircd/conn.rs # late-ssh/src/ircd/proj.rs # late-ssh/tests/ircd/smoke.rs
Emit +draft/reply alongside +reply on outbound replies and reaction TAGMSGs, matching what goguma and halloy send. Tag reaction TAGMSGs with server-time and a per-delivery msgid, mirroring ergo. Reactions to a nick now use a plain DM room lookup (new ChatRoom::get_dm) instead of get_or_create_dm, so a rejected reaction no longer creates an empty DM room.
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 15149220 | Triggered | Generic Password | a7769b5 | Makefile | View secret |
| 15149220 | Triggered | Generic Password | 8b6395c | late-core/src/db_test.rs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
- Mirror the upstream odd badge update (moderator + developer, canonical order) whose test fix landed on main just after our last merge point. - Public-room reaction deltas broadcast with no target list and sessions filter by membership, so assert None instead of a member list.
…ures # Conflicts: # late-ssh/src/app/lobby/daily/checkers.rs # late-ssh/src/app/lobby/daily/checkers_ui.rs # late-ssh/src/app/lobby/daily/reversi_ui.rs
…ures # Conflicts: # late-core/src/models/chat_message_test.rs # late-ssh/src/ircd/conn.rs # late-ssh/src/ircd/proj.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CAP negotiation with a first tier of IRCv3 caps (message-tags, server-time, echo-message) and uses them to bridge existing late.sh chat features to IRC clients: