Ref #1398: do not publish if tests fails#1411
Merged
Merged
Conversation
leplatrem
changed the title
leplatrem
added
bug
alexcottner
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1398
I'm trying to understand how we ended up deploying a version without the migration to
prefixed_principalswith which the group checking fails.I found a few details:
Could it be that a failing PR was merged and published?
Yes.
https://github.com/mozilla/remote-settings/actions/runs/28428058111/job/84236049980
The problem comes from Automerge without required checks.
By enabling automerge and approving, the failing PR was merged and deployed.
#1392