resampler: Bound delay_line::output reads to buffered frames#847
Open
kinetiknz wants to merge 1 commit into
Open
resampler: Bound delay_line::output reads to buffered frames#847kinetiknz wants to merge 1 commit into
kinetiknz wants to merge 1 commit into
Conversation
The pointer-returning delay_line::output copied frames_to_samples(frames_needed) samples out of delay_input_buffer unconditionally. When the delay line holds fewer frames than requested -- as happens at stream startup or during a capture underrun in a duplex stream that resamples only its output side -- this read past the end of the buffer. Copy only the buffered samples, zero-pad the remainder, and report the number of frames actually consumed, mirroring the underrun handling already present in cubeb_resampler_speex_one_way::output.
Collaborator
|
We should merge #841 instead, no? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pointer-returning delay_line::output copied frames_to_samples(frames_needed) samples out of delay_input_buffer unconditionally. When the delay line holds fewer frames than requested - as happens at stream startup or during a capture underrun in a duplex stream that resamples only its output side - this read past the end of the buffer.
Copy only the buffered samples, zero-pad the remainder, and report the number of frames actually consumed, mirroring the underrun handling already present in cubeb_resampler_speex_one_way::output.