Improve exception handing in langchain_tools.py#6149
Merged
suhaibmujahid merged 1 commit intoJun 12, 2026
Conversation
padenot
force-pushed
the
better-exceptions-searchfox
branch
from
c404501 to
986ca33
Compare
The searchfox-lib python bindings weren't using typed exceptions, but this got added in 0.16. This changes the following: - If the tool call fails because of a logic error (file not found, using wrong arguments, etc.), we log with error level, this goes to sentry. We want to track those and improve API/documentation/etc. -- this is generally actionnable - If the tool call fails because of a searchfox infra error (network, load, timeout etc.), we allow ourselve to retry, but if that still fails it is logged as a warning -- we can't do much.
padenot
force-pushed
the
better-exceptions-searchfox
branch
from
986ca33 to
cefd162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The searchfox-lib python bindings weren't using typed exceptions, but this got added in 0.16.
This changes the following: