Skip to content

Add path helper functions to resolve url.URL issue with Windows paths#266

Draft
checkinnuggets wants to merge 2 commits into
mozilla-ai:mainfrom
checkinnuggets:windows-path-fix
Draft

Add path helper functions to resolve url.URL issue with Windows paths#266
checkinnuggets wants to merge 2 commits into
mozilla-ai:mainfrom
checkinnuggets:windows-path-fix

Conversation

@checkinnuggets

Copy link
Copy Markdown

Original issue: #218
Further discussion with @peteski22 on PR: #221

(I note that CONTRIBUTING.md suggests following a PR template, but I'm not sure where to find that).

This PR was split out of #264. It addresses an issue where url.URL produces unexpected output on Windows

(@checkinnuggets to elaborate before publish)

… concatenation or direct calls to url.URL, which does not produce the expected result on Windows.
@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 56e4381b-30df-4acd-bc1b-47b701cd7813

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@checkinnuggets checkinnuggets changed the title Windows path fix Add path helper functions to resolve url.URL issue with Windows paths Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant