Add path helper functions to resolve url.URL issue with Windows paths#266
Draft
checkinnuggets wants to merge 2 commits into
Draft
Add path helper functions to resolve url.URL issue with Windows paths#266checkinnuggets wants to merge 2 commits into
checkinnuggets wants to merge 2 commits into
Conversation
… concatenation or direct calls to url.URL, which does not produce the expected result on Windows.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original issue: #218
Further discussion with @peteski22 on PR: #221
(I note that CONTRIBUTING.md suggests following a PR template, but I'm not sure where to find that).
This PR was split out of #264. It addresses an issue where url.URL produces unexpected output on Windows
(@checkinnuggets to elaborate before publish)