-
Notifications
You must be signed in to change notification settings - Fork 18
Add Windows-specific notes #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
javiermtorres
wants to merge
2
commits into
main
Choose a base branch
from
415-windocs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−1
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,13 +75,19 @@ This will: | |
|
|
||
| ## Building the CLI Tool | ||
|
|
||
| > **Note for Windows users:** Before starting the build process, set `ESAXX_DYNAMIC_LINK=1` to | ||
| enable the dynamic linking of the `esaxx-rs` library. Since this library forces static linking, | ||
| Mozilla.ai's fork is used instead. This fork only modifies the build process. | ||
|
|
||
| First, build the encoderfile CLI tool: | ||
|
|
||
| ```bash | ||
| cargo build --bin encoderfile --release | ||
| ``` | ||
|
|
||
| The CLI binary will be created at `./target/release/encoderfile`. | ||
| The CLI binary will be created at `./target/release/encoderfile`. This step also | ||
| creates the base executable that powers each encoderfile at | ||
| `target/release/encoderfile-runtime`. | ||
|
|
||
| Optionally, install it to your system: | ||
|
|
||
|
|
@@ -203,6 +209,11 @@ encoderfile: | |
| tokenizer_path: ./models/tokenizer.json | ||
| ``` | ||
|
|
||
| > **Note for Windows users:** Since precompiled binaries are not available | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. link to documentation on building from source |
||
| for Windows yet, make sure you use the `base_binary_path: target/release/encoderfile-runtime.exe` | ||
| property in the configuration file. This file is generated when | ||
| [bulding from source](#building-the-cli-tool). | ||
|
|
||
| ### Step 3: Build the Encoderfile | ||
|
|
||
| Build your encoderfile binary: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean? Is there a Mozilla.ai library fork?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The original https://github.com/Narsil/esaxx-rs library forces static linking, so we created a fork to allow dynamic linking: https://github.com/mozilla-ai/esaxx-rs-dyn-msvc/
Maybe we could try and push the changes to the main repository. Right now this was the only approach we could take.