fix: reject BatchProofQueue ingress collisions and fix commit accounting - #406
Open
0xIcarus wants to merge 1 commit into
Open
fix: reject BatchProofQueue ingress collisions and fix commit accounting#4060xIcarus wants to merge 1 commit into
0xIcarus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BatchProofQueuekeys slots on(author, batch_id)without the content digest. Two batches sharing the same key but different metadata can corrupt a slot thus grafting a proof onto a mismatched summary or vice versa and cause au64underflow inmark_committedwhennum_txnsdiverges.How Has This Been Tested?
4 regression tests in
batch_proof_queue_test.rscovering: summary-first collision, proof-first collision, colliding summary on an existing proof, and themark_committedunderflow case. All 11 tests in the module pass.Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.