ci: build tools and validator images produced together with aptos-node - #399
Open
apenzk wants to merge 1 commit into
Open
ci: build tools and validator images produced together with aptos-node#399apenzk wants to merge 1 commit into
apenzk wants to merge 1 commit into
Conversation
- broaden the publish-builder-images trigger to all pushes so tools + validator build per-commit, like aptos-node - add the validator image build (validator.Dockerfile) alongside tools
apenzk
requested review from
0xIcarus,
Primata,
ganymedio and
musitdev
as code owners
July 16, 2026 15:51
apenzk
requested review from
areshand,
nicholasflintwillow,
rubujubi and
vpallegar
and removed request for
0xIcarus,
Primata,
ganymedio and
musitdev
July 16, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The publish-builder-images workflow rebuilt the
toolsimage only on selectm1changes and did not build thevalidatorimage at all — so neither rode along with the per-commitaptos-nodeimage. This makestoolsandvalidatorbuild from the same commit asaptos-node, so every SHA carries a framework-consistentaptos-node/validator/toolsset.Why
toolsimage (bakes in the Move framework used for genesis) and thevalidator/aptos-nodeimage (the node VM) must come from the same commit — a genesis blob or migration built against one framework version only runs correctly on a matching node VM.aptos-nodeis produced at each commit, buttools/validatorare not built alongside it, so no single SHA has all three aligned.0x1::governed_gas_pool, which the post-move2 migration calls, is absent from the staletoolsframework and fails with aLINKER_ERROR. Producing all three together keeps them consistent at any SHA.