feat(cli): default chunked-publish large_packages address on Movement - #390
Draft
ganymedio wants to merge 3 commits into
Draft
feat(cli): default chunked-publish large_packages address on Movement#390ganymedio wants to merge 3 commits into
ganymedio wants to merge 3 commits into
Conversation
ganymedio
force-pushed
the
feat/large-packages-movement-default-address
branch
2 times, most recently
from
July 2, 2026 14:02
3b9dbca to
40f5272
Compare
`default_large_packages_module_address` resolved the `large_packages` module address from the chain ID but had no Movement branch, so on Movement mainnet/testnet it fell through to the localnet/devnet default (0x7), which has no such module deployed. Every chunked publish therefore required passing `--large-packages-module-address` by hand. Add a Movement branch pointing at the audited `large_packages` deployment at 0x5535c0246b3da2a0632edc13bac62aa352a9829adc2e060ed227955457aa9f06, published to the same account on Movement mainnet and testnet so one constant covers both networks. Update the `--large-packages-module-address` flag doc to describe the chain-id-based resolution.
ganymedio
force-pushed
the
feat/large-packages-movement-default-address
branch
from
July 2, 2026 14:11
40f5272 to
f3d9618
Compare
3 tasks
Author
|
putting in draft until #391 is resolved |
ganymedio
marked this pull request as draft
July 6, 2026 11:49
#391 removes is_movement_mainnet()/is_movement_testnet() and repoints is_mainnet()/is_testnet() at Movement's chain IDs, so the plain predicates now select the Movement large_packages address.
musitdev
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Point the default
large_packagesmodule address for--chunked-publishat the audited Movement deployment, so chunked publishing works out-of-the-box on Movement instead of requiring--large-packages-module-addresson every call.Uses deployment from #303
default_large_packages_module_addressgated the prod address onis_mainnet() || is_testnet(), which match chain IDs 1/2 (Aptos). Movement mainnet/testnet are chain IDs 126/250, so publishing there fell through to the localnet/devnet default (0x7), which has nolarge_packagesdeployed.Changes
chunked_publish.rs: setLARGE_PACKAGES_PROD_MODULE_ADDRESSto0x5535c0246b3da2a0632edc13bac62aa352a9829adc2e060ed227955457aa9f06and gate it onis_movement_mainnet() || is_movement_testnet().crates/aptos/src/common/types.rs: update the--large-packages-module-addressflag doc.Address
0x5535c0246b3da2a0632edc13bac62aa352a9829adc2e060ed227955457aa9f06— thelarge_packagesmodule, published to the same account on Movement mainnet and testnet.Testing
Build the CLI:
cargo build -p movement(binary attarget/debug/movement).On Movement testnet, run a chunked publish without
--large-packages-module-addressand confirm the staging call resolves to0x5535…::large_packages:cargo test -p movement --libpasses.movement move publish --chunked-publishon a package large enough to require chunking.movement move create-object-and-publish-package --chunked-publish. Example: MovementNames deployed as an object — https://github.com/movementlabsxyz/movement-name-service/tree/main/contracts