Skip to content

Feat: Add view function is_asset_type_dispatchable - #333

Merged
ganymedio merged 3 commits into
m1from
view-is-asset-type-dispatchable
Apr 30, 2026
Merged

Feat: Add view function is_asset_type_dispatchable#333
ganymedio merged 3 commits into
m1from
view-is-asset-type-dispatchable

Conversation

@ganymedio

@ganymedio ganymedio commented Apr 30, 2026

Copy link
Copy Markdown

Description

View function added in fungible_asset.move (see diff). Required for the changes in #299 Confidential Assets, so would be good to include for testing against testnet.

How Has This Been Tested?

Two unit tests:

  • test_is_asset_type_dispatchable_false_for_plain_fa
  • test_is_asset_type_dispatchable_true_with_derived_supply

@ganymedio
ganymedio requested review from apenzk and musitdev April 30, 2026 16:16
@ganymedio ganymedio changed the title Feat: dd view function is_asset_type_dispatchable Feat: Add view function is_asset_type_dispatchable Apr 30, 2026
@ganymedio
ganymedio merged commit 12b2a51 into m1 Apr 30, 2026
18 checks passed
@ganymedio
ganymedio deleted the view-is-asset-type-dispatchable branch April 30, 2026 21:00
apenzk added a commit that referenced this pull request May 7, 2026
## Description

Regenerates
[fungible_asset.md](https://github.com/movementlabsxyz/aptos-core/blob/docs/fungible-asset-regen/aptos-move/framework/aptos-framework/doc/fungible_asset.md)
to include the entry for
[is_asset_type_dispatchable](https://github.com/movementlabsxyz/aptos-core/blob/docs/fungible-asset-regen/aptos-move/framework/aptos-framework/sources/fungible_asset.move#L705).
The function was added by
[#333](#333) but the
auto-generated doc was not refreshed at that time, so the file has been
showing as dirty in working trees on every `cargo build` of
`aptos-cached-packages` (which re-runs the framework release-builder via
[build.rs](https://github.com/movementlabsxyz/aptos-core/blob/docs/fungible-asset-regen/aptos-move/framework/cached-packages/build.rs#L94)).
Landing the regen here clears that dirty state for everyone.

## How Has This Been Tested?

- This diff is the output of `cargo clean -p aptos-cached-packages &&
cargo build -p aptos-cached-packages` on `m1`.

## Type of Change

- [ ] New feature
- [ ] Bug fix
- [ ] Breaking change
- [ ] Performance improvement
- [ ] Refactoring
- [ ] Dependency update
- [x] Documentation update
- [ ] Tests

## Which Components or Systems Does This Change Impact?

- [ ] Validator Node
- [ ] Full Node (API, Indexer, etc.)
- [ ] Move/Aptos Virtual Machine
- [x] Aptos Framework
- [ ] Aptos CLI/SDK
- [ ] Developer Infrastructure
- [ ] Move Compiler
- [ ] Other (specify)

## Checklist

- [x] I have read and followed the
[CONTRIBUTING](https://github.com/aptos-labs/aptos-core/blob/main/CONTRIBUTING.md)
doc
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I identified and added all stakeholders and component owners
affected by this change as reviewers
- [x] I tested both happy and unhappy path of the functionality
- [ ] I have made corresponding changes to the documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants