chore(deps): upgrade vulnerable dependencies via cargo audit - #319
Open
larryl3u wants to merge 2 commits into
Open
chore(deps): upgrade vulnerable dependencies via cargo audit#319larryl3u wants to merge 2 commits into
larryl3u wants to merge 2 commits into
Conversation
Bump Rust toolchain to 1.95.0 and update multiple direct/transitive dependencies flagged by cargo audit. Vulnerability count: 36 -> 22. Direct dep bumps: - bytes 1.4 -> 1.11.1 - diesel 2.2 -> 2.2.3 (resolves 2.3.x via SDK) - diesel-async git -> 0.7.4 crates.io - diesel_migrations 2.1 -> 2.3.1 - git2 0.16 -> 0.19 - shadow-rs 0.16 -> 0.35 - tar 0.4.40 -> 0.4.45 - tracing-subscriber 0.3.17 -> 0.3.20 - aptos-indexer-processor-sdk -> tag v2.2.1 (matches processors-v2) - processor (indexer-processors-v2) -> 03b756b Transitive updates via cargo update: lz4_flex, quinn-proto, ring 0.17, rustls 0.21.x, rustls-webpki 0.102.x, time. Added jemalloc-sys shim in [patch.crates-io] to resolve jemalloc link conflict between local aptos-profiler and the transitive aptos-core pulled in by the indexer SDK (mirrors the same workaround used upstream). Local code adapted to API changes from the indexer SDK / processors-v2 upgrade: removed the deprecated EventsProcessor variant and migrated TransactionStreamConfig field names (auth_token is now Option, and the retry fields moved into reconnection_config; added backup_endpoints). Note: docker/builder/docker-bake-rust-all.hcl still pins rust:1.80.1-bullseye and needs a manual bump once the 1.95.0 image hash is known.
CI Nix builds were failing with "Stable 1.95.0 is not available" because flake.lock pinned rust-overlay to an August 2025 commit that predates the 1.95.0 release. Bump to the current rust-overlay HEAD so the toolchain file resolves.
Collaborator
|
Unfortunately, the CI/CD is still not working now. let's manual check the tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps Rust toolchain to 1.95.0 and upgrades a batch of dependencies flagged by
cargo audit. Vulnerability count: 36 → 22 (everything left requires major API rewrites or has no patched version).Direct dep bumps
bytes1.4 → 1.11.1diesel2.2 → 2.2.3 (resolves 2.3.x via SDK)diesel-asyncgit → 0.7.4 (crates.io — the blocker noted in the inline comment has released)diesel_migrations2.1 → 2.3.1git20.16 → 0.19shadow-rs0.16 → 0.35tar0.4.40 → 0.4.45tracing-subscriber0.3.17 → 0.3.20aptos-indexer-processor-sdk→ tagaptos-indexer-processor-sdk-v2.2.1(matches whatprocessors-v2pulls in — same commit viatag=instead ofrev=so Cargo dedupes it into a single crate instance)processor(aptos-indexer-processors-v2) →03b756b(the revision that fixes futures compatibility with aptos-core)Transitive updates (via
cargo update -p)lz4_flex,quinn-proto,ring0.17,rustls0.21.x,rustls-webpki0.102.x,time.New
[patch.crates-io]entryAdded a
jemalloc-sysshim entry that mirrors the same workaround used upstream — required because the neweraptos-indexer-processor-sdktransitively pulls in anotheraptos-corerev whoseaptos-profilerlinks totikv-jemalloc-sys, conflicting with our localaptos-profiler'sjemalloc-sys.Code adjustments required by the SDK / processors-v2 upgrade
EventsProcessorvariant usage fromcrates/aptos-localnet/src/processors.rs,crates/aptos/src/node/local_testnet/processors.rs, andaptos-move/aptos-workspace-server/src/services/processors.rs— it was removed from theprocessorcrate in PR feat!(indexer-grpc-utils): Cut out cloud-storage dependency from indexer-grpc #141 (Deprecate v1 tables and processors).TransactionStreamConfigcall sites to the new shape:auth_tokenis nowOption<String>, the retry-related fields collapsed into a singlereconnection_config: ReconnectionConfig, and a newbackup_endpointsfield was added.What's left / known follow-ups
docker/builder/docker-bake-rust-all.hclstill pinsrust:1.80.1-bullseye@sha256:.... This needs the 1.95.0 image hash — rundocker buildx imagetools inspect rust:1.95.0-bullseyeand update in a follow-up.ed25519-dalek 1→2,curve25519-dalek 3→4,ring 0.16→0.17,protobuf 2→3,rustls-webpki 0.100/0.101(via older transitivegoogle-cloud-*/tungstenite),tracing-subscriber 0.2(viaark-relations), andrsa(no patch available upstream).Test plan
cargo check --workspacepasses locally (confirmed on this branch)cargo auditcount drops from 36 → 22EventsProcessor