Temporarily increase the staking increase limit - #250
Conversation
a4dd79e to
7697f35
Compare
musitdev
left a comment
There was a problem hiding this comment.
stake increase limit is temporary and should not be activated when network become public. By merging in l1-migration we make it public. We should do like the epoch change, use a temporary framework to update the stake. I think we can even use the epoch change one because staking reward update has been merged in movement-migration branch as I remember.
I add the staking test and pass all unit test.
|
@musitdev That's a way yes, we could also just merge it then merge another PR that undoes this change prior to production migration next week. I think it's less overhead to do it in like that. |
ffb820a to
e4f44b9
Compare
|
Yes, but we need to apply both framework (the one with the staking increase deactivated and the final one) during the migration so if you have updated one it's harder to upgrade the first. What I say is that we can use the epoch activation one to load the initial staking and avoid to load/unload a specific framework to add the initial staking. |
| // | ||
| // Using high precision: 22 / 1,000,000 = 0.0022% per epoch | ||
| // Using high precision: Reward_rate = 0,000021761 / 100_000_000 = 2176 per epoch |
There was a problem hiding this comment.
@apenzk can we update the MIP to reflect this. Or have discussion on this formula.
There was a problem hiding this comment.
0.2176 bps is equivalent to APY = 10%. The value for 10% APR would be 0.2283.
Since APY is more familiar to the public the above code looks good and i agree its better to state 10% APY
I will update the MIP
cc @musitdev
There was a problem hiding this comment.
i misunderstood the discussion in the call - i thought you wanted to frequently or continuously update this configured number.
There was a problem hiding this comment.
movement-network/MIP#124 is updated. And i added some section about the APR to APY conversion.
e4f44b9 to
3cc3356
Compare
how to load the initial staking? we can also run a script to lower the threshold back to 50% without updating the framework. |
3cc3356 to
bf93295
Compare
bf93295 to
5002088
Compare
Description
Type of Change
Which Components or Systems Does This Change Impact?
How Has This Been Tested?
Key Areas to Review
Checklist