Skip to content

Temporarily increase the staking increase limit - #250

Merged
areshand merged 1 commit into
l1-migrationfrom
relax_stake_increase_limit
Nov 26, 2025
Merged

Temporarily increase the staking increase limit#250
areshand merged 1 commit into
l1-migrationfrom
relax_stake_increase_limit

Conversation

@areshand

Copy link
Copy Markdown
Collaborator

Description

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Other (specify)

How Has This Been Tested?

Key Areas to Review

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@areshand
areshand force-pushed the relax_stake_increase_limit branch 2 times, most recently from a4dd79e to 7697f35 Compare November 25, 2025 00:24
@areshand
areshand marked this pull request as ready for review November 25, 2025 00:24

@musitdev musitdev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stake increase limit is temporary and should not be activated when network become public. By merging in l1-migration we make it public. We should do like the epoch change, use a temporary framework to update the stake. I think we can even use the epoch change one because staking reward update has been merged in movement-migration branch as I remember.
I add the staking test and pass all unit test.

@0xmovses

0xmovses commented Nov 25, 2025

Copy link
Copy Markdown

@musitdev That's a way yes, we could also just merge it then merge another PR that undoes this change prior to production migration next week. I think it's less overhead to do it in like that.

@areshand
areshand force-pushed the relax_stake_increase_limit branch from ffb820a to e4f44b9 Compare November 25, 2025 16:59
@musitdev

Copy link
Copy Markdown

Yes, but we need to apply both framework (the one with the staking increase deactivated and the final one) during the migration so if you have updated one it's harder to upgrade the first. What I say is that we can use the epoch activation one to load the initial staking and avoid to load/unload a specific framework to add the initial staking.

//
// Using high precision: 22 / 1,000,000 = 0.0022% per epoch
// Using high precision: Reward_rate = 0,000021761 / 100_000_000 = 2176 per epoch

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apenzk can we update the MIP to reflect this. Or have discussion on this formula.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.2176 bps is equivalent to APY = 10%. The value for 10% APR would be 0.2283.

Since APY is more familiar to the public the above code looks good and i agree its better to state 10% APY

I will update the MIP

cc @musitdev

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i misunderstood the discussion in the call - i thought you wanted to frequently or continuously update this configured number.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

movement-network/MIP#124 is updated. And i added some section about the APR to APY conversion.

@areshand
areshand force-pushed the relax_stake_increase_limit branch from e4f44b9 to 3cc3356 Compare November 25, 2025 17:43
@areshand

areshand commented Nov 25, 2025

Copy link
Copy Markdown
Collaborator Author

Yes, but we need to apply both framework (the one with the staking increase deactivated and the final one) during the migration so if you have updated one it's harder to upgrade the first. What I say is that we can use the epoch activation one to load the initial staking and avoid to load/unload a specific framework to add the initial staking.

how to load the initial staking? we can also run a script to lower the threshold back to 50% without updating the framework.

@areshand
areshand force-pushed the relax_stake_increase_limit branch from 3cc3356 to bf93295 Compare November 25, 2025 22:23
@areshand
areshand force-pushed the relax_stake_increase_limit branch from bf93295 to 5002088 Compare November 25, 2025 22:25
@areshand
areshand merged commit c3b705d into l1-migration Nov 26, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants