Skip to content

Cherry pick MIP-124 (#227) - #236

Merged
0xmovses merged 22 commits into
l1-migrationfrom
cherry-pick-mip-124
Oct 30, 2025
Merged

Cherry pick MIP-124 (#227)#236
0xmovses merged 22 commits into
l1-migrationfrom
cherry-pick-mip-124

Conversation

@0xmovses

@0xmovses 0xmovses commented Oct 22, 2025

Copy link
Copy Markdown

Based on MIP-124.

Implements these changes:
https://www.notion.so/movementlabs/Staking-reward-using-GGP-28118675b2d780848e30c0c7e51d47cc

In the folder aptos-move/framework/aptos-framework run aptos move test to run all test.
Or aptos move test -f stake to run stake related tests.


See the #227 original PR

Based on [MIP-124](movement-network/MIP#124).

Implements this changes:
https://www.notion.so/movementlabs/Staking-reward-using-GGP-28118675b2d780848e30c0c7e51d47cc

In the folder `aptos-move/framework/aptos-framework` run `movement move
test` to run all test.
Or `movement move test -f stake `to run stake related tests.

---------

Co-authored-by: musitdev <philippe.delrieu@free.fr>
@0xmovses 0xmovses changed the title update rewards and governed pool MIP-124 (#227) Cherry pick MIP-124 (#227) Oct 22, 2025
Comment thread aptos-move/framework/move-stdlib/sources/configs/features.move
Comment thread movement-migration/framework-upgrades/scripts/feature-flag-reconfig.move Outdated
@0xmovses
0xmovses requested a review from areshand October 22, 2025 23:32
@areshand

areshand commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

for testing, can we test if we can upgrade the mainnet mirror with this change?

Comment thread aptos-move/framework/move-stdlib/sources/configs/features.move
Comment thread aptos-move/framework/move-stdlib/sources/configs/features.move
Comment thread aptos-move/framework/move-stdlib/sources/configs/features.move
@0xmovses

Copy link
Copy Markdown
Author

Upgrade on mainnet mirror successful 🟢
0-move-stdlib:

Transaction submitted: https://explorer.aptoslabs.com/txn/0xecced6d791156f4d650941ca0d85c53bdd375718d8a81ae800d696d68ad2910e?network=custom
{
  "Result": {
    "transaction_hash": "0xecced6d791156f4d650941ca0d85c53bdd375718d8a81ae800d696d68ad2910e",
    "gas_used": 4437,
    "gas_unit_price": 100,
    "sender": "000000000000000000000000000000000000000000000000000000000a550c18",
    "sequence_number": 12978,
    "success": true,
    "timestamp_us": 1761238051317952,
    "version": 14957459,
    "vm_status": "Executed successfully"
  }
}

1-aptos-stdlib:

Transaction submitted: https://explorer.aptoslabs.com/txn/0x600d47b5d5f62810288aacca5fcb7f161fd4f5bfd5a7c80e7a445e07f93747ee?network=custom
{
  "Result": {
    "transaction_hash": "0x600d47b5d5f62810288aacca5fcb7f161fd4f5bfd5a7c80e7a445e07f93747ee",
    "gas_used": 9718,
    "gas_unit_price": 100,
    "sender": "000000000000000000000000000000000000000000000000000000000a550c18",
    "sequence_number": 12979,
    "success": true,
    "timestamp_us": 1761238198159662,
    "version": 14958368,
    "vm_status": "Executed successfully"
  }
}

2-aptos-framework

Transaction submitted: https://explorer.aptoslabs.com/txn/0x3d5d7eb3d06d1027417227ca1b51355145db114844ffa9ff877ff1565288c311?network=custom
{
  "Result": {
    "transaction_hash": "0x3d5d7eb3d06d1027417227ca1b51355145db114844ffa9ff877ff1565288c311",
    "gas_used": 22612,
    "gas_unit_price": 100,
    "sender": "000000000000000000000000000000000000000000000000000000000a550c18",
    "sequence_number": 12980,
    "success": true,
    "timestamp_us": 1761238266380645,
    "version": 14958793,
    "vm_status": "Executed successfully"
  }
}

3-aptos-token

Transaction submitted: https://explorer.aptoslabs.com/txn/0x00e252add74bb187451f86607eb32e858d484a7359e38a8cbb8750569278e609?network=custom
{
  "Result": {
    "transaction_hash": "0x00e252add74bb187451f86607eb32e858d484a7359e38a8cbb8750569278e609",
    "gas_used": 3235,
    "gas_unit_price": 100,
    "sender": "000000000000000000000000000000000000000000000000000000000a550c18",
    "sequence_number": 12981,
    "success": true,
    "timestamp_us": 1761238396028508,
    "version": 14959596,
    "vm_status": "Executed successfully"
  }
}

4-aptos-token-objects

Transaction submitted: https://explorer.aptoslabs.com/txn/0xacb799e6f57c296f924287942e54f26295158854c6cb3b5082d4c6ede53aa39b?network=custom
{
  "Result": {
    "transaction_hash": "0xacb799e6f57c296f924287942e54f26295158854c6cb3b5082d4c6ede53aa39b",
    "gas_used": 3354,
    "gas_unit_price": 100,
    "sender": "000000000000000000000000000000000000000000000000000000000a550c18",
    "sequence_number": 12982,
    "success": true,
    "timestamp_us": 1761238485492660,
    "version": 14960151,
    "vm_status": "Executed successfully"
  }
}

@0xmovses

Copy link
Copy Markdown
Author

Many of the tests in delegation_pool are failing, I think it's something simple tho. Checking it out.

@0xmovses
0xmovses requested a review from areshand October 29, 2025 16:58
Comment thread aptos-move/framework/move-stdlib/sources/configs/features.move Outdated
Comment thread aptos-move/framework/move-stdlib/sources/configs/features.move
@0xmovses

0xmovses commented Oct 30, 2025

Copy link
Copy Markdown
Author

Regarding this error on mainnet mirror:

cargo run -p aptos -- move run --function-id '0x1::governed_gas_pool::initialize_governed_gas_pool_extension' --assume-yes --url http://54.212.18.191:8080/v1
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.37s
     Running `/Users/movses/mvmt/mvmt-aptos-core/target/debug/aptos move run --function-id '0x1::governed_gas_pool::initialize_governed_gas_pool_extension' --assume-yes --url 'http://54.212.18.191:8080/v1'`
{
  "Error": "Simulation failed with status: FUNCTION_RESOLUTION_FAILURE\nExecution failed with message: Function 0x1::governed_gas_pool::initialize_governed_gas_pool_extension does not exist"
}

I attempted using a compiled script instead of CLI with these steps:

  1. aptos move compile --package-dir aptos-move/move-examples/scripts/update_reconfiguration --bytecode-version 7
  2. cargo run -p aptos move run-script --compiled-script-path movement-migration/ggp/build/ggp/bytecode_scripts/initialize_governed_gas_pool_extension.mv --url http://54.212.18.191:8080/v1

And yield this error:

{
  "Error": "Simulation failed with status: LOOKUP_FAILED"
}

Which seems a variant of the same cause. I know now what the error is. It must be the mainnet mirror state not tallying with the framework on the base branch.

@0xmovses

Copy link
Copy Markdown
Author

GGP Extension Successfully initialized on Mainnet Mirror

cargo run -p aptos move run-script --compiled-script-path movement-migration/ggp/build/ggp/bytecode_scripts/initialize_governed_gas_pool_extension.mv --url http://54.212.18.191:8080/v1
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.39s
     Running `target/debug/aptos move run-script --compiled-script-path movement-migration/ggp/build/ggp/bytecode_scripts/initialize_governed_gas_pool_extension.mv --url 'http://54.212.18.191:8080/v1'`
Do you want to submit a transaction for a range of [59800 - 89700] Octas at a gas unit price of 100 Octas? [yes/no] >
y
Transaction submitted: https://explorer.aptoslabs.com/txn/0x5ad000b1ed564c032a2527bbf1b8538f099f1b205d9e91385d7e717cb71dc8e9?network=custom
{
  "Result": {
    "transaction_hash": "0x5ad000b1ed564c032a2527bbf1b8538f099f1b205d9e91385d7e717cb71dc8e9",
    "gas_used": 598,
    "gas_unit_price": 100,
    "sender": "000000000000000000000000000000000000000000000000000000000a550c18",
    "sequence_number": 12993,
    "success": true,
    "timestamp_us": 1761841961609607,
    "version": 18682618,
    "vm_status": "Executed successfully"
  }
}

@0xmovses

Copy link
Copy Markdown
Author

Re-generating Move2 upgrade scripts after last commit, await to test mainnet mirror with the new scripts.

@0xmovses

Copy link
Copy Markdown
Author

Upgrade successful 🟢

@0xmovses
0xmovses requested a review from areshand October 30, 2025 17:49
Comment thread types/src/on_chain_config/aptos_features.rs Outdated
@0xmovses
0xmovses merged commit 896682d into l1-migration Oct 30, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants