[partnerPR] Update rewards and governed pool MIP-124 - #232
Merged
Conversation
save progress
## Description - Reviewers should test against local mainnet state. Sebs EC2 instance did not have a port exposed so I went with the mainnet mirror. Which now has the feature reconfig applied. Note that the feature `CALCULATE_TRANSACTION_FEE_FOR_DISTRIBUTION = 96` can only be enabled after Move2 upgrade. Hence why it is not enabled here (it is not available on `movement-migration` framework) - See the script `feature-flag-reconfig.move` for what features are being enabled and disabled. Note that after Move2 upgrade, further features to be enabled which are only available after the upgrade. 1. Compile the feature flag upgrade script ``` movement move compile --package-dir movement-migration/framework-upgrades --bytecode-version 6 ``` 2.Run the script ``` movement move run-script --compiled-script-path movement-migration/framework-upgrades/build/feature-flag-reconfig/bytecode_scripts/main.mv ``` Should receive success output. Mainnet Mirror tx ``` Do you want to submit a transaction for a range of [11200 - 16800] Octas at a gas unit price of 100 Octas? [yes/no] > y Transaction submitted: https://explorer.movementlabs.xyz/txn/0x7a92eff1e1e973e881a046aaebaa72e42a1f6a1daaa3bec45167657c8d8c67ad?network=custom { "Result": { "transaction_hash": "0x7a92eff1e1e973e881a046aaebaa72e42a1f6a1daaa3bec45167657c8d8c67ad", "gas_used": 112, "gas_unit_price": 100, "sender": "000000000000000000000000000000000000000000000000000000000a550c18", "sequence_number": 12966, "success": true, "timestamp_us": 1759411858121293, "version": 28646125, "vm_status": "Executed successfully" } } ```
This reverts commit d1b0545.
### Description Based on [MIP-124](movement-network/MIP#124). Implements this changes: https://www.notion.so/movementlabs/Staking-reward-using-GGP-28118675b2d780848e30c0c7e51d47cc ### Testing In the folder `aptos-move/framework/aptos-framework` run `movement move test` to run all test. Or `movement move test -f stake `to run stake related tests. --------- Co-authored-by: musitdev <philippe.delrieu@free.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was cherry picked from
0ae9d6f8721954e7428a9feefac83ae52bff0355onmovement-migrationwhich is the squash commit from PR #227.We need this commits now on
movementfor testing purposes.