Governed Gas Pool - #114
Merged
Merged
Conversation
l-monninger
marked this pull request as draft
December 16, 2024 07:40
15 tasks
0xmovses/genesis ggp
feat: add test helper to set chain_id
0xmovses
self-requested a review
January 27, 2025 03:06
0xmovses
approved these changes
Jan 27, 2025
0xmovses
reviewed
Jun 24, 2025
| if (amount_to_burn > storage_fee_refunded) { | ||
| let burn_amount = amount_to_burn - storage_fee_refunded; | ||
| transaction_fee::burn_fee(gas_payer, burn_amount); | ||
| if (features::governed_gas_pool_enabled()) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces the
governed_gas_pooldesigned in MIP-52 to theaptos_framework. When the featureGOVERNED_GAS_POOLis enabled, the transaction epilogue will deposit gas fees into the pool.Outstanding
specneeds to be updated both forFA(something Aptos had not yet done) and governed gas pool usage. Or else new tests need to be configured which do not yet have a template.transaction_validation.spec.move. However, this should likely be implemented intransaction_fee.spec.moveinstead.governed_gas_poolw.r.t to epoch boundaries needs to validated in the corresponding full node PR.governed_gas_poolfeature path does not account or allow for any net positive transactions as is clear in the flow control intransaction_validation.move. Whether this is appropriate still needs to be validated.