[draft] MIP-44: NB-FFS Governed Gas Pool - #44
Open
l-monninger wants to merge 2 commits into
Open
Conversation
l-monninger
changed the title
0xmovses
self-requested a review
November 5, 2024 14:57
0xmovses
suggested changes
Nov 5, 2024
0xmovses
left a comment
0xmovses
left a comment
Contributor
There was a problem hiding this comment.
I'll be following up with a PR that will merge into this MIP PR #44. I'll be working on,
- Updates required to
aptos_governance.movein order for us to use it. - Ref Implementation for creating the Governed Gas Pool
- Ref Implementation for network upgrade scripts.
| @@ -0,0 +1,53 @@ | |||
| # MIP-42: AB-FFS Governed Gas Pool | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # MIP-42: AB-FFS Governed Gas Pool | |
| # MIP-42: Governed Gas Pool |
This is no longer coupled with AB or AB-FFS
| @@ -0,0 +1,53 @@ | |||
| # MIP-42: AB-FFS Governed Gas Pool | |||
| - **Description**: Introduces a governed gas pool for AB-FFS which allows for initial period wherein used gas is not recirculated. | |||
| - **Authors**: [Liam Monninger](mailto:liam@movementlabs.xyz) | |||
Contributor
There was a problem hiding this comment.
Suggested change
| - **Authors**: [Liam Monninger](mailto:liam@movementlabs.xyz) | |
| - **Authors**: [Liam Monninger, Richard Melkonian](mailto:liam@movementlabs.xyz, mailto:richard@movementlabs.xyz) |
| ## Abstract | ||
| We propose a governed gas pool both as provisional and potentially permanent solution to the supply problem described in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38). This solution consists of depositing funds into a pool on the L2, and holding votes against actions for the recirculation of said funds. | ||
|
|
||
| The concept of a governed gas pool can be applied generally to manage migrations between systems. For example, the governed gas pool could be used to transition from the "Trickle-back" mechanism referenced in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38) to [MIP-42](https://github.com/movementlabsxyz/MIP/pull/42), as is used as an example amongst others herein. |
Contributor
There was a problem hiding this comment.
Suggested change
| The concept of a governed gas pool can be applied generally to manage migrations between systems. For example, the governed gas pool could be used to transition from the "Trickle-back" mechanism referenced in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38) to [MIP-42](https://github.com/movementlabsxyz/MIP/pull/42), as is used as an example amongst others herein. | |
| The concept of a governed gas pool can be applied generally to manage migrations between systems. For example, the governed gas pool could be used to transition from the "Trickle-back" mechanism referenced in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38) to [MIP-42](https://github.com/movementlabsxyz/MIP/pull/42), as is used as an example amongst others herein. As demonstrated in the diagram, the governed gas pool can be used to provide liquidity for a variety of protocol operations, liquidity of L1 Rewards, Trickle Back liquidity or grants. To use the funds for any of these activities a proposal would have to pass and a network upgrade or migration would also have to occur after governance approves the proposal. It is recommended to read generally around [aptos-governance](https://aptos.web3doc.top/concepts/governance/) and how it is implemented. Because of its tie to aptos-staking (which we do not use), we will be required to make modifications to `aptos_governance.move`. Changes for this are suggested and laid in MIP(##). |
| The concept of a governed gas pool can be applied generally to manage migrations between systems. For example, the governed gas pool could be used to transition from the "Trickle-back" mechanism referenced in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38) to [MIP-42](https://github.com/movementlabsxyz/MIP/pull/42), as is used as an example amongst others herein. | ||
|
|
||
| ## Motivation | ||
| The AB-FFS under fixed supply presents several challenges presented in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38). This MIP seeks to address the question of where used gas funds should be deposited with a simple and flexible solution. By simply depositing funds into a pool and holding votes against actions for the recirculation of said funds, we can create a system that can provide a short-term solution to the supply problem and generalize to other systems. |
Contributor
There was a problem hiding this comment.
Suggested change
| The AB-FFS under fixed supply presents several challenges presented in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38). This MIP seeks to address the question of where used gas funds should be deposited with a simple and flexible solution. By simply depositing funds into a pool and holding votes against actions for the recirculation of said funds, we can create a system that can provide a short-term solution to the supply problem and generalize to other systems. | |
| The AB-FFS under fixed supply presents several challenges presented in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38). This MIP seeks to address the question of where used gas funds should be deposited with a simple and flexible solution. By simply depositing funds into a pool and holding votes against actions for the recirculation of said funds, we can create a system that can provide a solution to the supply problem and generalize to other systems. |
|
|
||
| 1. Gas used on the L2 MUST be deposited into the Governed Gas Pool. | ||
| 2. The Governed Gas Pool MUST disperse deposited funds according to a proposal made by Proposers which is enacted by a vote of Executors. | ||
| 3. The Governed Gas Pool SHOULD define a maximum emissions rate for the pool s.t. the governing body cannot engage in Byzantine or other malicious behavior. |
Contributor
There was a problem hiding this comment.
Suggested change
| 3. The Governed Gas Pool SHOULD define a maximum emissions rate for the pool s.t. the governing body cannot engage in Byzantine or other malicious behavior. | |
| 3. The Governed Gas Pool SHOULD define a maximum emissions rate for the pool s.t. the governing body cannot engage in Byzantine or other malicious behavior. | |
| 4. Governance MUST be implemented using the [aptos_governance](https://github.com/movementlabsxyz/aptos-core/blob/andyjsbell/atomic-bridge/aptos-move/framework/aptos-framework/sources/aptos_governance.move) module provided by aptos core. | |
| 5. Any necessary upgrades or migrations required to `aptos_framework` MUST be included within a proposal and voted upon by the governing body. |
Contributor
Author
There was a problem hiding this comment.
Governed gas pool is not specific to Aptos that would be a separate MIP.
Contributor
There was a problem hiding this comment.
Ok, in that case I'll put the reference implementation there also, as the ref implementation I wrote assumes usage of aptos_governance.move.
apenzk
suggested changes
Nov 5, 2024
| @@ -0,0 +1,53 @@ | |||
| # MIP-42: AB-FFS Governed Gas Pool | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # MIP-42: AB-FFS Governed Gas Pool | |
| # MIP-44: Governed Gas Pool |
Contributor
There was a problem hiding this comment.
extends beyond swap-bridge-swap FFS
| @@ -0,0 +1,53 @@ | |||
| # MIP-42: AB-FFS Governed Gas Pool | |||
| - **Description**: Introduces a governed gas pool for AB-FFS which allows for initial period wherein used gas is not recirculated. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| - **Description**: Introduces a governed gas pool for AB-FFS which allows for initial period wherein used gas is not recirculated. | |
| - **Description**: Introduces a governed gas pool on L2 which allows for initial period wherein used gas is not recirculated. |
| - **Desiderata**: [MD-38](https://github.com/movementlabsxyz/MIP/pull/38) | ||
|
|
||
| ## Abstract | ||
| We propose a governed gas pool both as provisional and potentially permanent solution to the supply problem described in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38). This solution consists of depositing funds into a pool on the L2, and holding votes against actions for the recirculation of said funds. |
Contributor
There was a problem hiding this comment.
Suggested change
| We propose a governed gas pool both as provisional and potentially permanent solution to the supply problem described in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38). This solution consists of depositing funds into a pool on the L2, and holding votes against actions for the recirculation of said funds. | |
| We propose a governed gas pool both as provisional and potentially permanent solution to the supply problem described in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38). This solution consists of depositing `$L2MOVE` funds into a pool on the L2, and holding votes against actions for the recirculation of said funds. |
| The concept of a governed gas pool can be applied generally to manage migrations between systems. For example, the governed gas pool could be used to transition from the "Trickle-back" mechanism referenced in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38) to [MIP-42](https://github.com/movementlabsxyz/MIP/pull/42), as is used as an example amongst others herein. | ||
|
|
||
| ## Motivation | ||
| The AB-FFS under fixed supply presents several challenges presented in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38). This MIP seeks to address the question of where used gas funds should be deposited with a simple and flexible solution. By simply depositing funds into a pool and holding votes against actions for the recirculation of said funds, we can create a system that can provide a short-term solution to the supply problem and generalize to other systems. |
Contributor
There was a problem hiding this comment.
Suggested change
| The AB-FFS under fixed supply presents several challenges presented in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38). This MIP seeks to address the question of where used gas funds should be deposited with a simple and flexible solution. By simply depositing funds into a pool and holding votes against actions for the recirculation of said funds, we can create a system that can provide a short-term solution to the supply problem and generalize to other systems. | |
| The requirement for fixed supply presents several challenges and where the challenges dependent on the selected design, see Appendix A1 in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38). One particular concern is that if fees are burnt they would decrease the supply. Hence fees, should be collected instead. | |
| This MIP seeks to address the question of where used gas funds should be deposited with a simple and flexible solution. By simply depositing funds into a pool and holding votes against actions for the recirculation of said funds, we can create a system that can provide a short-term solution to the supply problem and generalize to other systems. |
| ## Specification | ||
|  | ||
|
|
||
| 1. Gas used on the L2 MUST be deposited into the Governed Gas Pool. |
Contributor
There was a problem hiding this comment.
Governed Gas Pool is a new term. its definition should be added to the Glossary and this MD should be referenced from Glossary, see
#45
|
|
||
| 2. For security, we propose the constraint that all of these dispersals SHOULD be $O(1)$. | ||
|
|
||
| For example, the pool can securely--without risk of gas attack--disperse into [MIP-42](https://github.com/movementlabsxyz/MIP/pull/42) withholdings if said action only involves depositing funds into the account controlling that account. In the case that this action were linear in the size of the approved liquidity providers, for example, gas pool proposals good be subject to gas attacks which would prevent critical actions for recirculating funds to take place at the appropriate time. |
Contributor
There was a problem hiding this comment.
what is liquidity providers job? liquidity providers are not yet defined in this document
Contributor
Author
There was a problem hiding this comment.
This is only alluded to in the diagram, but the governed gas pool could disperse to liquidity providers elsewhere in the network.
Contributor
There was a problem hiding this comment.
thx. but the role of the liquidity providers is still not defined nor clear.
|
|
||
| For example, the pool can securely--without risk of gas attack--disperse into [MIP-42](https://github.com/movementlabsxyz/MIP/pull/42) withholdings if said action only involves depositing funds into the account controlling that account. In the case that this action were linear in the size of the approved liquidity providers, for example, gas pool proposals good be subject to gas attacks which would prevent critical actions for recirculating funds to take place at the appropriate time. | ||
|
|
||
| 3. When considering mechanisms which are not synchronous and atomic, we propose that the Governed Gas Pool SHOULD only be considered responsible for the security of the synchronous and atomic step constituting the initial dispersal. |
Contributor
There was a problem hiding this comment.
this is not clear. please elaborate in the above line
Contributor
Author
There was a problem hiding this comment.
Does the example below not clarify?
Contributor
There was a problem hiding this comment.
so why "synchronous". what does synchronous mean in this context. can synchronous be removed?
|
|
||
| 3. When considering mechanisms which are not synchronous and atomic, we propose that the Governed Gas Pool SHOULD only be considered responsible for the security of the synchronous and atomic step constituting the initial dispersal. | ||
|
|
||
| For example, the "Trickle-back" mechanism referenced in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38) could be performed with an initial dispersal into the bridge pool. However, the ultimate effect of those funds returning to L1 settlement rewards would not be guaranteed once set dispersal occurs. Thus, when analyzing the security of the "Trickle-back" mechanism, one would consider the actions of the Governed Gas Pool as secure insofar as the dispersal into the bridge pool is secure. The remainder of the mechanism would be considered separately. |
Contributor
There was a problem hiding this comment.
Suggested change
| For example, the "Trickle-back" mechanism referenced in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38) could be performed with an initial dispersal into the bridge pool. However, the ultimate effect of those funds returning to L1 settlement rewards would not be guaranteed once set dispersal occurs. Thus, when analyzing the security of the "Trickle-back" mechanism, one would consider the actions of the Governed Gas Pool as secure insofar as the dispersal into the bridge pool is secure. The remainder of the mechanism would be considered separately. | |
| For example, the "Trickle-back" mechanism referenced in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38) could be performed with an initial dispersal through the bridge (or into the L2 Native Bridge DEX in case of the swap-bridge-swap solution). However, the ultimate effect of those funds returning to L1 settlement rewards would not be guaranteed once set dispersal occurs. Thus, when analyzing the security of the "Trickle-back" mechanism, one would consider the actions of the Governed Gas Pool as secure insofar as the dispersal into the bridge pool is secure. The remainder of the mechanism would be considered separately. |
| For example, the "Trickle-back" mechanism referenced in [MD-38](https://github.com/movementlabsxyz/MIP/pull/38) could be performed with an initial dispersal into the bridge pool. However, the ultimate effect of those funds returning to L1 settlement rewards would not be guaranteed once set dispersal occurs. Thus, when analyzing the security of the "Trickle-back" mechanism, one would consider the actions of the Governed Gas Pool as secure insofar as the dispersal into the bridge pool is secure. The remainder of the mechanism would be considered separately. | ||
|
|
||
| ### Recommendations for Governance of the Governed Gas Pool | ||
| We provide a series of recommendations for the governance of the Governed Gas Pool to account for common phenomena in this system. More detailed proposals, however, such be set forth in MIPs governing a specific Governed Gas Pool implementation. |
0xmovses
self-requested a review
November 6, 2024 07:37
0xmovses
reviewed
Nov 6, 2024
apenzk
changed the title
apenzk
changed the title
franck44
added
check_for_outdated
Draft MD/MIP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MIP-44