docs: fix basePath on raw internal links in the recipe picker - #156
Merged
Conversation
Raw `<a href="/…">` tags are not basePath-prefixed by Next, so on the
Pages deployment (served under /bubo/) they resolved to the domain root and
404'd. Prefix them with the asset() helper:
- "schedule it" → asset('/operate/#schedule-the-poller') — also lands on the
Schedule-the-poller section instead of the page top.
- prerequisite links (e.g. the self-hosted "OpenAI-compatible config" →
/configuration) → asset() for internal hrefs, external http links untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "schedule it" link (and the self-hosted recipe's "OpenAI-compatible config" prereq link) were raw
<a href="/…">tags. Next only basePath-prefixes<Link>and_next/assets, not raw<a>, so on the Pages deployment (served under/bubo/) these resolved to the domain root (mountainowl.github.io/operate) and 404'd.Fix
schedule it→asset('/operate/#schedule-the-poller')— basePath-prefixed and now lands on the Schedule the poller section instead of the page top.asset()for internal hrefs; externalhttplinks stay untouched (keeptarget=_blank).Verification
next buildgreen.asset('/operate/#schedule-the-poller')→/bubo/operate/#schedule-the-poller; the operate page carriesid="schedule-the-poller".